Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Clear unit test warnings #1518

Merged
merged 3 commits into from
Jul 30, 2019
Merged

Clear unit test warnings #1518

merged 3 commits into from
Jul 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 29, 2019

Overall change: Clear unit test warnings while running tests.
Code changes:

  • Update SecitonLabel test to include children
  • Update Brand test svg fillrule to fillRule
  • Update SitewideLinks link to use unique keys.
  • Update snapshots

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@ghost ghost added the ws-home Tasks for the WS Home Team label Jul 29, 2019
@ghost ghost self-assigned this Jul 29, 2019
@ghost ghost marked this pull request as ready for review July 29, 2019 14:36
@ghost ghost requested review from dr3, j-pendlebury, pjlee11 and sareh as code owners July 29, 2019 14:36
Copy link
Contributor

@j-pendlebury j-pendlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👍

@david-boydell
Copy link

Super, this is ready for merge.

@david-boydell david-boydell self-assigned this Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants