Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add service locale to inputProvider callback #1244

Merged
merged 4 commits into from
Jul 16, 2019
Merged

Add service locale to inputProvider callback #1244

merged 4 commits into from
Jul 16, 2019

Conversation

ryanmccombe
Copy link
Contributor

@ryanmccombe ryanmccombe commented Jul 16, 2019 •
edited
Loading

Dependency for #1185

Overall change: The inputProvider function within storybook helpers will now call the render function with an additional locale property based on the service selected

Code changes:

  • Add locales for all services
  • inputProvider now includes locale in the callback argument
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@ryanmccombe ryanmccombe self-assigned this Jul 16, 2019
@ryanmccombe ryanmccombe marked this pull request as ready for review July 16, 2019 14:53
@ryanmccombe ryanmccombe mentioned this pull request Jul 16, 2019
Merged
3 tasks
dr3
dr3 approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after version fix

thekp
thekp approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@thekp thekp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryanmccombe
Copy link
Contributor Author

No QA needed here as no consumers are implementing this functionality yet

@ryanmccombe ryanmccombe merged commit 6e1f649 into latest Jul 16, 2019
@sareh sareh deleted the add-locale-to-inputProvider branch August 7, 2019 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dr3 dr3 dr3 approved these changes

@thekp thekp thekp approved these changes

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@pjlee11 pjlee11 Awaiting requested review from pjlee11

@sareh sareh Awaiting requested review from sareh

Assignees

@ryanmccombe ryanmccombe

Labels
simorgh-core-stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanmccombe @dr3 @thekp