Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add esm entry for packages that already have main #1233

Merged
merged 11 commits into from
Jul 16, 2019
Merged

Add esm entry for packages that already have main #1233

merged 11 commits into from
Jul 16, 2019

Conversation

dr3
Copy link
Contributor

@dr3 dr3 commented Jul 16, 2019 •
edited
Loading

Contributes to #557

Overall change: Adds ESM entry to all packages that previously had a 'main'

Code changes:

  • Adds ESM entry to all packages that previously had a 'main'
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@dr3 dr3 self-assigned this Jul 16, 2019
@dr3 dr3 marked this pull request as ready for review July 16, 2019 09:04
thekp
thekp suggested changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@thekp thekp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version bump and changelog update for psammead-image and psammead-story-promo

packages/components/psammead-image-placeholder/CHANGELOG.md Outdated Show resolved Hide resolved
packages/components/psammead-story-promo-list/CHANGELOG.md Outdated Show resolved Hide resolved
thekp
thekp approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@thekp thekp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you just need to resolve the conflicts 🛠 🔨

Drew McMillan and others added 2 commits July 16, 2019 16:05
Apply suggestions from code review
61caf0f 
Co-Authored-By: Phil Lee <phil.lee.ext@bbc.co.uk>
Merge branch 'latest' into ESM-most
9ceb84c
pjlee11
pjlee11 approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@pjlee11 pjlee11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dr3
Copy link
Contributor Author

dr3 commented Jul 16, 2019

No testing needed, will regression when injested.

@dr3 dr3 merged commit cad14a9 into latest Jul 16, 2019
@dr3 dr3 deleted the ESM-most branch July 16, 2019 21:13
This was referenced Oct 3, 2019
Closed
Closed
This was referenced Oct 15, 2019
Closed
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jroebu14 jroebu14 jroebu14 approved these changes

@pjlee11 pjlee11 pjlee11 approved these changes

@thekp thekp thekp approved these changes

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@sareh sareh Awaiting requested review from sareh

Assignees

@dr3 dr3

Labels
simorgh-core-stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dr3 @jroebu14 @pjlee11 @thekp