Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

bump component dependencies in psammead components #1038

Merged
merged 6 commits into from
Jul 11, 2019
Merged

bump component dependencies in psammead components #1038

merged 6 commits into from
Jul 11, 2019

Conversation

thekp
Copy link
Contributor

@thekp thekp commented Jul 10, 2019 •
edited
Loading

Resolves: n/a

Overall change: Bump the version of components within other components.

Code changes:

  • bump version
  • updated package-lock && snapshots if required
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@thekp thekp self-assigned this Jul 10, 2019
@thekp thekp marked this pull request as ready for review July 10, 2019 14:19
@thekp thekp changed the title bump component dependencies bump component dependencies in psammead components Jul 10, 2019
dr3
dr3 suggested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visually hidden text and timestamp container need changelogs

@PriyaKR PriyaKR self-assigned this Jul 11, 2019
@PriyaKR
Copy link
Contributor

PriyaKR commented Jul 11, 2019

The only issue i am seeing with this PR is paragraph component on storybook doesn't show expected BBCNassim font for arabic.
Refer this PR - #941

@jamesbhobbs jamesbhobbs merged commit 3876102 into latest Jul 11, 2019
@jamesbhobbs jamesbhobbs deleted the bump-component-dependency branch July 11, 2019 11:57
@jamesbhobbs
Copy link
Contributor

@PriyaKR @thekp please create an issue to fix that forwards

@thekp
Copy link
Contributor Author

thekp commented Jul 11, 2019

The only issue i am seeing with this PR is paragraph component on storybook doesn't show expected BBCNassim font for arabic.
Refer this PR - #941

this is currently not an issue as we have not yet configured the font-family for arabic
config: https://github.com/bbc/psammead/blob/latest/packages/utilities/psammead-styles/src/font-families.js

@thekp thekp mentioned this pull request Jul 12, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jroebu14 jroebu14 jroebu14 approved these changes

@dr3 dr3 dr3 approved these changes

@chris-hinds chris-hinds chris-hinds approved these changes

@jamesbhobbs jamesbhobbs jamesbhobbs approved these changes

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@pjlee11 pjlee11 Awaiting requested review from pjlee11

@sareh sareh Awaiting requested review from sareh

Assignees

@PriyaKR PriyaKR

@thekp thekp

Labels
simorgh-core-stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thekp @PriyaKR @jamesbhobbs @jroebu14 @dr3 @chris-hinds