allow to specify TargetRubyVersion 2.5 #5101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walf443
changed the title
walf443
changed the title
walf443
changed the title
walf443
force-pushed
the
support_ruby25
branch
2 times, most recently
from
354d8e8 to
b069ca7
Compare
walf443
force-pushed
the
support_ruby25
branch
from
b069ca7 to
d2a56ac
Compare
|
👍 |
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
Apr 27, 2020
rubocop looks at the .ruby-version file to find out which ruby version to target when linting files. We use rubocop 0.49.1 which does not have support for ruby 2.5 yet. We would first need rubocop 0.52.0 to bring in: rubocop/rubocop#5101 When the file got updated, rubocop has not been run by CI since rake_modules/taskgen.rb does not consider a change to .ruby-version to be sufficient to run it. But that breaks any future changes touching a ruby file. This reverts commit 037adb5. Bug: T250538 Change-Id: If45d94da22e8e8d898ba6bd9d73a3be8ea244812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parser gem v2.4.0 was released. It start support ruby25, So rubocop can allow to specify TargetRubyVersion 2.5 for preparing ruby 2.5.0 release.
https://github.com/whitequark/parser/blob/master/CHANGELOG.md#v2401-2017-11-13
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).rake spec) are passing.rake internal_investigation.and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).