Add same_line style for multiline brace layouts #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panthomakos
force-pushed
the
brace-layout-same-line
branch
2 times, most recently
from
60acaf6 to
d7fdc6a
Compare
| add_offense(node, :expression, self.class::ALWAYS_NEW_LINE_MESSAGE) | ||
| end | ||
|
|
||
| def handle_same_line(node) |
There was a problem hiding this comment.
Only this code was added. The rest of the code has been moved from check_brace_layout for clarity.
The `Style/Multiline*BraceLayout` cops now supports the `same_line` enforced style. This style forces the closing brace to always be on the same line as the last element. For reference see rubocop#2914
panthomakos
force-pushed
the
brace-layout-same-line
branch
from
d7fdc6a to
705b922
Compare
Neodelf
pushed a commit
to Neodelf/rubocop
that referenced
this pull request
Oct 15, 2016
The `Style/Multiline*BraceLayout` cops now supports the `same_line` enforced style. This style forces the closing brace to always be on the same line as the last element. For reference see rubocop#2914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Style/Multiline*BraceLayoutcops now supports thesame_lineenforced style. This style forces the closing brace to always be on the
same line as the last element.
For reference see #2914