More fixes #2515
Merged
More fixes #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks fine to me, as it's the nest method call is not something that would result in a method argument for the outer method. |
| @@ -662,6 +662,12 @@ Style/SingleLineBlockParams: | |||
| Style/SingleLineMethods: | |||
| AllowIfMethodIsEmpty: true | |||
|
|
|||
| Style/SpecialGlobalVars: | |||
| EnforcedStyle: use_verbose_names | |||
There was a problem hiding this comment.
I'd say those are "descriptive" and the others are "cryptic". :-)
Let's rename verbose to descriptive or english. I think verbose carries a different connotation.
alexdowad
force-pushed
the
more_fixes
branch
from
4bf2731 to
775bf09
Compare
|
Thanks for all the helpful comments. PR updated. I will probably push several more fixes to this branch over the coming days, but if and when you want to merge it, please go ahead; I can open another one. |
This was referenced Dec 19, 2015
alexdowad
force-pushed
the
more_fixes
branch
3 times, most recently
from
bf8096b to
2897183
Compare
|
Apart from the failing build, all changes look good. Your |
alexdowad
force-pushed
the
more_fixes
branch
2 times, most recently
from
f10c5dc to
209acf5
Compare
…Vars This is for people who like squinting at cryptic variable names and trying to remember what they are for.
It checks for things like:
foo(bar 1, 2)
The --stdin CLI option causes RuboCop to read source from stdin. Previously, if this was combined with --autocorrect, an 'infinite loop' error would result. Instead, autocorrect the code and print it to stdout (after an easily-identifiable delimiter which separates it from other information printed to stdout).
If 'attr_writer' appears after an access modifier, that means it's not useless.
…]= are the same
Previously, it would flag this:
if something
array << value
else
array[index] = value
end
…to be 'namespace'
Like this:
module Info
VERSION = '1.2'
AUTHOR = 'No-one in particular'
end
Such classes and modules won't be flagged even if they have no documentation
comment.
alexdowad
force-pushed
the
more_fixes
branch
from
209acf5 to
8d4d6eb
Compare
Do some major refactoring to ConditionalAssignment at the same time.
…fig from rubocop
This is not allowed:
inherit_gem:
rubocop: config/default.yml
...because it causes confusion. User configuration is ALREADY merged with the
default configuration, without explicitly inheriting it like this.
Thanks to Jonas Arvidsson for suggesting this.
…exits scope
So code like this:
if condition
raise 'exception'
else
ok
end
...will be flagged. Instead, it should be:
raise 'exception' if condition
ok
alexdowad
force-pushed
the
more_fixes
branch
from
8d4d6eb to
0594eb8
Compare
|
Updated PR. Fixed build. Also added one new cop... see the last commit. |
This catches things like:
if condition
do_x
do_z
else
do_y
do_z
end
...which should be:
if condition
do_x
else
do_y
end
do_z
alexdowad
force-pushed
the
more_fixes
branch
from
66e6977 to
318c056
Compare
|
I like the new cop - quite useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my next batched GH-issue-fixin' PR.
Regarding the new cop requested by @agrimm, which checks for paren-challenged method calls nested inside a paren-privileged method call, what do you think about this:
Is it good, or bad?