Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails/UniqBeforePluck to ignore uniq with block #3125

Merged

Conversation

tejasbubane
Copy link
Contributor

@tejasbubane tejasbubane commented May 10, 2016

Before submitting a PR make sure the following are checked:

  • Wrote good commit messages.
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it)
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.

Issue #3122
Also moved around some code in specs to use shared_context for ignored cases
Might conflict with #3124

@rrosenblum
Copy link
Contributor

The code is going to need to be rebased. Aside from that, it looks good to me.

Issue rubocop#3112
Also moved around some code in specs to use shared_context for ignored cases
@tejasbubane tejasbubane force-pushed the fix-uniq-before-pluck-cop-with-block branch from bef7a46 to 15085f2 Compare May 11, 2016 07:12
@tejasbubane
Copy link
Contributor Author

@rrosenblum Rebased. There was a conflict in CHANGELOG. Not sure why the build did not get triggered this time. cc:/ @bbatsov

@bbatsov bbatsov merged commit e217b21 into rubocop:master May 11, 2016
@tejasbubane tejasbubane deleted the fix-uniq-before-pluck-cop-with-block branch June 8, 2016 10:45
Neodelf pushed a commit to Neodelf/rubocop that referenced this pull request Oct 15, 2016
Issue rubocop#3112
Also moved around some code in specs to use shared_context for ignored cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants