Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested classes with explicit superclass are no longer flagged as an offense #3112

Closed
jspanjers opened this issue May 5, 2016 · 0 comments
Closed

Nested classes with explicit superclass are no longer flagged as an offense #3112

jspanjers opened this issue May 5, 2016 · 0 comments

Comments

@jspanjers
Copy link
Contributor

Since commit 0f40a84

(version 0.38.0),

using

Style/ClassAndModuleChildren:
   EnforcedStyle: nested

the following code:

class FooClass::BarClass < Super
end

is no longer flagged as an offense. That does not seem right.
@jspanjers jspanjers mentioned this issue May 5, 2016
Merged
bbatsov pushed a commit that referenced this issue May 7, 2016
@jspanjers @bbatsov
[Fix #3112] Fix Style/ClassAndModuleChildren for nested classes wit…
9d8407c 
…h explicit superclass (#3113)
@tejasbubane tejasbubane mentioned this issue May 10, 2016
Merged
9 tasks
tejasbubane added a commit to tejasbubane/rubocop that referenced this issue May 11, 2016
@tejasbubane
Fix Rails/UniqBeforePluck to ignore uniq with block
15085f2 
Issue rubocop#3112
Also moved around some code in specs to use shared_context for ignored cases
bbatsov pushed a commit that referenced this issue May 11, 2016
@tejasbubane @bbatsov
Fix Rails/UniqBeforePluck to ignore uniq with block (#3125)
e217b21 
Issue #3112
Also moved around some code in specs to use shared_context for ignored cases
Neodelf pushed a commit to Neodelf/rubocop that referenced this issue Oct 15, 2016
@jspanjers @Neodelf
[Fix rubocop#3112] Fix Style/ClassAndModuleChildren for nested clas…
2e7fad6 
…ses with explicit superclass (rubocop#3113)
Neodelf pushed a commit to Neodelf/rubocop that referenced this issue Oct 15, 2016
@tejasbubane @Neodelf
Fix Rails/UniqBeforePluck to ignore uniq with block (rubocop#3125)
13d206d 
Issue rubocop#3112
Also moved around some code in specs to use shared_context for ignored cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jspanjers