Support rules proto 6.0.0 #1482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NilsIrl
requested review from
aaronsky,
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
There was a problem hiding this comment.
Does this break the rules_swift default MODULE.bazel configuration of rules_proto => 5.3.0-21.7 because proto/toolchains.bzl doesn't exist?
https://github.com/bazelbuild/rules_proto/tree/5.3.0-21.7/proto
|
Yep, I think MODULE.bazel would need to be updated too |
|
Typically, rules_swift doesn't update dependencies unless it needs some portion of, for example, rules_proto 6.X.X in its implementation. I'd recommend applying this change via something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1199