Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_disable_custom_test_launcher #1069

Closed
UebelAndre opened this issue Dec 16, 2021 · 0 comments · Fixed by #1095
Closed

incompatible_disable_custom_test_launcher #1069

UebelAndre opened this issue Dec 16, 2021 · 0 comments · Fixed by #1095

Comments

@UebelAndre
Copy link
Collaborator

Currently rust_test targets use a custom test launcher to configure environment variables for use during tests. In #960 a change was made to switch tests to use Bazel's testing.TestEnvironment provider. This solves for situations where using --run_under resulted in inconsistent behavior as the binary being run was not the expected test executable but the custom test launcher. As of now the custom test launcher is only used when execpath is used in a rust_test.env value as the launcher expands execpath variables to absolute paths, where the TestEnvironment variable does not. In many cases, this change in behavior can be worked around in code where issues with --run_under could not. This flag tracks the deprecation of the custom test launcher in rules_rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant