Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

Update rules_nodejs to 5.0.0 #74

Open
rzhw opened this issue Sep 6, 2021 · 5 comments
Open

Update rules_nodejs to 5.0.0 #74

rzhw opened this issue Sep 6, 2021 · 5 comments

Comments

@rzhw
Copy link
Contributor

rzhw commented Sep 6, 2021

Per #73 (comment), these rules are incompatible with rules_nodejs 4.0.0 due to the @bazel/worker dep being outdated.

One option is to update to the last 3.x release of @bazel/worker as suggested in #73 (comment) as that relaxes the rules_nodejs version constraint.

However, absent of a strong reason to avoid doing so, upgrading rules_nodejs, and consequentially @bazel/worker, to the latest version, 4.0.0 should be the approach taken.

@alexeagle
Copy link

rules_nodejs 5.0.0 is now out.

@rzhw are you still maintaining this repo?

@rzhw rzhw changed the title Update rules_nodejs to 4.0.0 Update rules_nodejs to 5.0.0 Jan 26, 2022
@rzhw
Copy link
Contributor Author

rzhw commented Jan 26, 2022

Thanks for the heads up.

Unfortunately I've had my hands full and have dropped the ball on this for the time being.

I've done some preliminary work on this, so if I can get the time I'll have a look and put it up if it's a useful start.

@alexeagle
Copy link

No worries, I know that rule maintenance is hard to prioritize.

In the meantime, should we give new users some guidance about what's recommended for using postcss with Bazel? Should they just use the generated rule from the postcss npm package rather than this custom ruleset?

@rzhw
Copy link
Contributor Author

rzhw commented Feb 4, 2022

That sounds like a reasonable approach for consistency with other rules_nodejs generated rules, versus the more idiomatic approach taken here.

@titanous
Copy link

titanous commented Mar 2, 2022

I've done a lot of this work in #66 and it's working locally (except the wrapper option, because run_node isn't setting up the node_modules properly for the runner when it's not the executable). It's failing in CI, and I've run out of time budget to keep working on this but feel free to keep pushing it forward.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants