-
Notifications
You must be signed in to change notification settings - Fork 13
Update rules_nodejs to 5.0.0 #74
Comments
rules_nodejs 5.0.0 is now out. @rzhw are you still maintaining this repo? |
Thanks for the heads up. Unfortunately I've had my hands full and have dropped the ball on this for the time being. I've done some preliminary work on this, so if I can get the time I'll have a look and put it up if it's a useful start. |
No worries, I know that rule maintenance is hard to prioritize. In the meantime, should we give new users some guidance about what's recommended for using postcss with Bazel? Should they just use the generated rule from the postcss npm package rather than this custom ruleset? |
That sounds like a reasonable approach for consistency with other rules_nodejs generated rules, versus the more idiomatic approach taken here. |
I've done a lot of this work in #66 and it's working locally (except the wrapper option, because |
Per #73 (comment), these rules are incompatible with
rules_nodejs
4.0.0 due to the@bazel/worker
dep being outdated.One option is to update to the last 3.x release of
@bazel/worker
as suggested in #73 (comment) as that relaxes therules_nodejs
version constraint.However, absent of a strong reason to avoid doing so, upgrading
rules_nodejs
, and consequentially@bazel/worker
, to the latest version, 4.0.0 should be the approach taken.The text was updated successfully, but these errors were encountered: