windows_utils.bzl: Escaping \ and " before passing args to bash scrip… #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
|
I guess I need to add a test for this. |
alexeagle
approved these changes
Mar 4, 2020
| * limitations under the License. | ||
| */ | ||
|
|
||
| const process = require('process') |
There was a problem hiding this comment.
nit: the process global variable is defined in a nodejs context without needing a require statement
| @@ -96,7 +96,12 @@ set RUNFILES_MANIFEST_ONLY=1 | |||
| call :rlocation "{sh_script}" run_script | |||
| for %%a in ("{bash_bin}") do set "bash_bin_dir=%%~dpa" | |||
| set PATH=%bash_bin_dir%;%PATH% | |||
| "{bash_bin}" -c "!run_script! %*" | |||
| set args=%* | |||
There was a problem hiding this comment.
would be nice to have some comments here to explain that this is escaping the arguments
There was a problem hiding this comment.
Cool, comments added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t with quote
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#1671
What is the new behavior?
On Windows, passing command line args to node_binary is more consistent with Linux.
Does this PR introduce a breaking change?
Other information