feat(esbuild): default log-level flag to warning, unless overridden #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
approved these changes
May 10, 2021
mattem
force-pushed
the
feat/esbuild-log-level
branch
from
70faedc
to
09bd662
Compare
alexeagle
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esbuild defaults the
--log-levelflag toinfowhich includes an output file summary (I think this used to be a separate flag 🤷). This can lead to spammy build logs and redundant output under bazel as output file paths will be duplicated.Unless overridden by the user with the
argsattribute, default the--log-levelflag towarningwhich only includes erorrs and warnings about the build, and not the output file summary.