fix(concatjs): devserver not passing through tags to all targets #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a devserver target is currently testonly and marked with the `manual` tag (e.g. if used for e2e testing), then the `manual` tag is not passed to all targets exposed by the ConcatJS devserver macro. i.e. the manifest alias is exposed and results in the manifest to be built -> which inherently means that the actual devserver target is built even though it has the `manual` tag.
devversion
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
alexeagle
approved these changes
May 7, 2021
twheys
pushed a commit
to twheys/rules_nodejs
that referenced
this pull request
Jan 13, 2022
…el-contrib#2646) If a devserver target is currently testonly and marked with the `manual` tag (e.g. if used for e2e testing), then the `manual` tag is not passed to all targets exposed by the ConcatJS devserver macro. i.e. the manifest alias is exposed and results in the manifest to be built -> which inherently means that the actual devserver target is built even though it has the `manual` tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a devserver target is currently testonly and marked with the
manualtag (e.g. if used for e2e testing), then themanualtag is not passed to all targets exposed by the ConcatJS devserver
macro. i.e. the manifest alias is exposed and results in the
manifest to be built -> which inherently means that the actual
devserver target is built even though it has the
manualtag.