Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): output path for .json in root package #2602

Merged
merged 1 commit into from
Apr 10, 2021
Merged

fix(typescript): output path for .json in root package #2602

merged 1 commit into from
Apr 10, 2021

Conversation

alexeagle
Copy link
Collaborator

Fixes #2598

@google-cla google-cla bot added the cla: yes label Apr 9, 2021
@mattem mattem merged commit 1c50e96 into bazel-contrib:stable Apr 10, 2021
@joneshf
Copy link

joneshf commented Apr 11, 2021 •
edited
Loading

It seems like this change also fixes #2365. That right?

Put another way, it seems like #2598 was a dupe of #2365.

@mattem mattem mentioned this pull request Apr 13, 2021
Closed
@DanielWisenhoffDebricked DanielWisenhoffDebricked mentioned this pull request Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattem mattem mattem approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

@soldair soldair Awaiting requested review from soldair

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ts_project expects json output path incorrectly for root target
3 participants
@alexeagle @joneshf @mattem