fix(esbuild): set correct base url when rule is at root #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
reviewed
Mar 5, 2021
| @@ -7,6 +7,9 @@ | |||
| "tslib": "1.9.0", | |||
| "typescript": "3.5.3" | |||
| }, | |||
| "dependencies": { | |||
| "chalk": "4.1.0" | |||
There was a problem hiding this comment.
Should a package-lock.json also be changing...?
There was a problem hiding this comment.
yeah looks like we should be using npm ci when we install deps for examples
There was a problem hiding this comment.
Nice catch @jbedard, I should have regenerated the lock file, will update.
Currently we can't use npm ci during install of the deps in integration tests as the package replacement gets in the way, or is that not what you meant?
alexeagle
approved these changes
Mar 5, 2021
| @@ -7,6 +7,9 @@ | |||
| "tslib": "1.9.0", | |||
| "typescript": "3.5.3" | |||
| }, | |||
| "dependencies": { | |||
| "chalk": "4.1.0" | |||
There was a problem hiding this comment.
yeah looks like we should be using npm ci when we install deps for examples
mattem
force-pushed
the
fix/esbuild_base_url
branch
from
588b11b
to
92a2699
Compare
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the esbuild rule is in the root
BUILD.bazelfile,rule_pathis empty, splitting on this results in a list with one empty string, which is then translated into one path segment. Whenrule_pathis empty, the rule is already in the correct base path.This also adds an npm dependency to the example to exercise node_module resolution when bundling.
closes #2503