Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ':' instead of '=' for esbuild 'define' argument #2469

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

mattsoulanille
Copy link
Contributor

@mattsoulanille mattsoulanille commented Feb 17, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

esbuild passes global definitions as --define=the_var=value instead of --define:the_var=value as documented.
Issue Number: N/A

What is the new behavior?

Pass global definitions as --define:the_var=value.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Feb 17, 2021
@mattsoulanille
Copy link
Contributor Author

I think there's a similar bug with --external. I can create a PR for it as well.

@mattsoulanille mattsoulanille marked this pull request as ready for review February 17, 2021 06:25
Copy link
Collaborator

@mattem mattem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah if you are able to submit a PR for --external too that would be great

@mattem mattem merged commit b0fddae into bazel-contrib:stable Feb 17, 2021
@mattsoulanille mattsoulanille deleted the fix_esbuild_define branch February 17, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants