Memory leak of ts_library

[ouchuji]

🐞 bug report

Affected Rule

ts_library

Is this a regression?

No.

Description

Build lot of `ts_library` target via command such as `bazel build src/...` would cause a memory leak problem.

The bazel would create a lot of node processes to compile the ts.

Then the computor memory is all ate by these node processes.

I found that this commit caused this problem.
feat(typescript): use run_node helper to execute tsc 066a52c
And I change the code like below and the problem is solved, node processes number became normal.

And I make deep debuging, found the extra arg --bazel_node_modules_manifest=%s to the tsc_wrapper caused this probel, and I comment this, the problem is solved too.

🔬 Minimal Reproduction

It looks great when build a single ts_library target, but not great when build lots of ts targets via bazel build ....

🔥 Exception or Error

No exception, but the computor memory is overflow.

🌍 Your Environment

Operating System:

  
Ubutu 18.04 LTS
  

Output of bazel version:

  
2.1.0
  

Rules_nodejs version:

(Please check that you have matching versions between WORKSPACE file and @bazel/* npm packages.)

  
1.5.0
  

Anything else relevant?

[alexeagle]

That's fantastic debugging! Thank you for digging into this and finding the root cause, that should help us find the time to fix it.

[chris-codaio]

Just guessing here, but it's probably the root cause of recent reports in #1027.