fix(builtin): preserve lone $ in templated_args for legacy support #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@filipesilva Ran into this in angular-cli repo after upgrading to 1.5.0 |
alexeagle
approved these changes
Apr 1, 2020
This fixes a corner case that should be very rare so I'm still happy we got the feature in for 1.5. |
This preservation may be removed in a future version so that templated_args behaves the same as the built-in *_binary and *_test args
gregmagolan
force-pushed
the
preserve_lone_$
branch
from
685ed42
to
a5c878b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an unintentional breaking change introduced in 1.5.0.
This preservation may be removed in a future version so that templated_args behaves the same as the built-in *_binary and *_test args