feat(typescript): add devmode_target, devmode_module, prodmode_target & prodmode_module attributes

[gregmagolan]

This allows users control over the language level & module formats produced by both the dev and prod outputs of ts_library

NB: the tsconfig bazelOpts.googmodule if set will still override the module format to CommonJS & bazelOpts.devmodeTargetOverride will trump the devmode_target attribute so this is non-breaking. In a future major release bazelOpts.devmodeTargetOverride will be removed.

Control over devmode module format is requested by @filipesilva for the angular-cli bazel migration.

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature (please, look at the "Scope of the project" section in the README.md file)
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[filipesilva]

Heya, one thing I want to highlight is that in the CLI we don't want this just for devmode. We want packages to be distributed in commonjs as well.

[gregmagolan]

Heya, one thing I want to highlight is that in the CLI we don't want this just for devmode. We want packages to be distributed in commonjs as well.

Yup. I got that. By devmode output I'm referring the the ts_library rule's .js output which is called devmode in the rule. Prodmode outputs .mjs in oss land which is useful for rollup_bundle but less ergonomic for adding to a pkg_npm.

[gregmagolan]

Waiting on approval on bazelbuild/rules_typescript#492 before landing this so that we don't diverge from rules_typescript on this.

[filipesilva]

@gregmagolan thanks for explaining it to me, I did not know that's what devmode meant in this context.

[gregmagolan]

After discussing with Evan Martin from Google and with Alex Eagle, decided to pivot here and use oss only ts_library attributes to configure the target & module in devmode & prodmode.

The bazelOpts.devmodeTargetOverride is not used at all in google3 so it can be removed from rules_typescript in the future. The Angular repo can be updated to use the devmode_target attribute and this PR will unblock the angular-cli as they need to override the module format in devmode which they can do with devmode_module.

Matching prodmode attributes added for symmetry and consistency.

[alexeagle]

Still LGTM