Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builtin): strip BOM when parsing package.json #1453

Merged
merged 1 commit into from
Dec 14, 2019
Merged

fix(builtin): strip BOM when parsing package.json #1453

merged 1 commit into from
Dec 14, 2019

Conversation

alexeagle
Copy link
Collaborator

Fixes #1448

@alexeagle alexeagle merged commit c65d9b7 into bazel-contrib:master Dec 14, 2019
@philwo
Copy link
Contributor

philwo commented Dec 17, 2019

This commit turned the rules_nodejs pipeline red. Apparently the same test failure happened twice during presubmit, but then somehow passed on the third attempt.

Do you want to look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soldair soldair soldair approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails when including paralleljs
4 participants
@alexeagle @philwo @soldair @googlebot