Skip to content

Commit

Permalink
fix(builtin): propogate tags to both generated targets in generated_f…
Browse files Browse the repository at this point in the history
…ile_test
  • Loading branch information
Greg Magolan authored and alexeagle committed Jun 8, 2021
1 parent 4e44178 commit c4403fc
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions internal/generated_file_test/generated_file_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg
else:
src_dbg = src

tags = kwargs.pop("tags", [])

loc = "$(rootpath %s)"
nodejs_test(
name = name,
Expand All @@ -37,6 +39,7 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg
loc % generated,
],
data = data,
tags = tags,
visibility = visibility,
**kwargs
)
Expand All @@ -48,5 +51,6 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg
entry_point = "@build_bazel_rules_nodejs//internal/generated_file_test:bundle.js",
templated_args = ["--out", loc % src, loc % src_dbg, loc % generated],
data = data,
tags = tags,
visibility = visibility,
)

0 comments on commit c4403fc

Please sign in to comment.