fix(typescript): only expect .js outs for .tsx? srcs (#2118)

Fixes #2115
bazel-contrib · Aug 16, 2020 · 83688a1 · 83688a1
1 parent b97f3e9
commit 83688a1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/packages/typescript/internal/ts_project.bzl b/packages/typescript/internal/ts_project.bzl
@@ -215,7 +215,11 @@ validate_options = rule(
 
 def _out_paths(srcs, outdir, rootdir, ext):
     rootdir_replace_pattern = rootdir + "/" if rootdir else ""
-    return [_join(outdir, f[:f.rindex(".")].replace(rootdir_replace_pattern, "") + ext) for f in srcs if not f.endswith(".d.ts") and not f.endswith(".json")]
+    return [
+        _join(outdir, f[:f.rindex(".")].replace(rootdir_replace_pattern, "") + ext)
+        for f in srcs
+        if not f.endswith(".d.ts") and (f.endswith(".ts") or f.endswith(".tsx"))
+    ]
 
 def ts_project_macro(
         name = "tsconfig",

diff --git a/packages/typescript/test/ts_project/json/BUILD.bazel b/packages/typescript/test/ts_project/json/BUILD.bazel
@@ -5,6 +5,8 @@ SRCS = [
     "subdir/a.ts",
     "subdir/foo.json",
     "bar.json",
+    # Regression test for #2115 - should not expect baz.js output
+    "baz.svg",
 ]
 
 ts_project(

diff --git a/packages/typescript/test/ts_project/json/baz.svg b/packages/typescript/test/ts_project/json/baz.svg