feat(builtin): flip the default of the strict_visibility flag on the …

…npm and yarn install rules to True
bazel-contrib · Oct 27, 2020 · 2c34857 · 2c34857
1 parent 6790755
commit 2c34857
Show file tree

Hide file tree

Showing 29 changed files with 148 additions and 10 deletions.
diff --git a/e2e/concatjs_devserver/package.json b/e2e/concatjs_devserver/package.json
@@ -10,6 +10,7 @@
     "jasmine": "2.8.0",
     "protractor": "^5.4.2",
     "rxjs": "^6.5.2",
+    "tslib": "^1.9.0",
     "typeorm": "^0.2.17",
     "typescript": "2.7.x"
   },

diff --git a/e2e/jasmine/package.json b/e2e/jasmine/package.json
@@ -9,6 +9,7 @@
     "test": "bazel test ..."
   },
   "devDependencies": {
-    "jasmine": "2.99.0"
+    "jasmine": "2.99.0",
+    "jasmine-core": "2.99.0"
   }
 }
diff --git a/e2e/jasmine/yarn.lock b/e2e/jasmine/yarn.lock
@@ -260,6 +260,11 @@ istanbul-reports@^3.0.2:
     html-escaper "^2.0.0"
     istanbul-lib-report "^3.0.0"
 
+jasmine-core@2.99.0:
+  version "2.99.0"
+  resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-2.99.0.tgz#c105ab5222da45f1b0a10580383f5adbbff56d2c"
+  integrity sha1-wQWrUiLaRfGwoQWAOD9a27/1bSw=
+
 jasmine-core@~2.99.0:
   version "2.99.1"
   resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-2.99.1.tgz#e6400df1e6b56e130b61c4bcd093daa7f6e8ca15"

diff --git a/examples/angular/package.json b/examples/angular/package.json
@@ -22,6 +22,8 @@
         "@ngrx/store": "9.2.0",
         "@nguniversal/express-engine": "^9.0.0",
         "date-fns": "1.30.1",
+        "domino": "^2.1.2",
+        "reflect-metadata": "^0.1.2",
         "rxjs": "6.5.3",
         "systemjs": "6.1.2",
         "tslib": "2.0.0",
@@ -50,9 +52,12 @@
         "@types/jasmine": "3.4.0",
         "@types/node": "6.14.6",
         "core-js": "2.6.9",
+        "express": "^4.14.0",
         "firebase-tools": "7.1.0",
         "history-server": "^1.3.1",
         "html-insert-assets": "^0.6.0",
+        "jasmine": "2.8.0",
+        "jasmine-core": "2.8.0",
         "karma": "~4.1.0",
         "karma-chrome-launcher": "2.2.0",
         "karma-firefox-launcher": "1.1.0",
@@ -63,6 +68,7 @@
         "requirejs": "2.3.6",
         "rollup": "^2.3.4",
         "terser": "4.3.1",
+        "tmp": "0.1.0",
         "typescript": "^3.9.0"
     },
     "scripts": {

diff --git a/examples/angular_view_engine/package.json b/examples/angular_view_engine/package.json
@@ -50,6 +50,8 @@
         "firebase-tools": "7.1.0",
         "history-server": "^1.3.1",
         "html-insert-assets": "^0.6.0",
+        "jasmine": "2.8.0",
+        "jasmine-core": "2.8.0",
         "karma": "~4.1.0",
         "karma-chrome-launcher": "2.2.0",
         "karma-firefox-launcher": "1.1.0",
@@ -63,6 +65,7 @@
         "rollup-plugin-amd": "^4.0.0",
         "rollup-plugin-re": "^1.0.7",
         "terser": "4.3.1",
+        "tmp": "0.1.0",
         "typescript": "3.4.5"
     },
     "scripts": {

diff --git a/examples/app/package.json b/examples/app/package.json
@@ -6,6 +6,7 @@
     "@bazel/terser": "^2.2.2",
     "@bazel/typescript": "^2.2.2",
     "@types/jasmine": "3.3.15",
+    "@types/node": "^12.12.2",
     "html-insert-assets": "^0.6.0",
     "http-server": "^0.11.1",
     "less": "^3.10.3",

diff --git a/examples/app/yarn.lock b/examples/app/yarn.lock
@@ -100,6 +100,11 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-10.14.21.tgz#4a9db7ef1d1671c0015e632c5fa3d46c86c58c1e"
   integrity sha512-nuFlRdBiqbF+PJIEVxm2jLFcQWN7q7iWEJGsBV4n7v1dbI9qXB8im2pMMKMCUZe092sQb5SQft2DHfuQGK5hqQ==
 
+"@types/node@^12.12.2":
+  version "12.12.68"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-12.12.68.tgz#dd5acf4a52a458ff1d9ef4fd66406fba0afbbb33"
+  integrity sha512-3RW2s24ewB7F9dAHvgb9FRvNHn6nO9IK6Eaknbz7HTOe2a5GVne5XbUh5+YA+kcCn67glyHhClUUdFP73LWrgQ==
+
 "@types/node@^12.7.2":
   version "12.7.8"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-12.7.8.tgz#cb1bf6800238898bc2ff6ffa5702c3cadd350708"

diff --git a/examples/create-react-app/package.json b/examples/create-react-app/package.json
@@ -3,6 +3,7 @@
   "version": "0.1.0",
   "private": true,
   "dependencies": {
+    "@testing-library/dom": "^6.15.0",
     "@testing-library/jest-dom": "^4.2.4",
     "@testing-library/react": "^9.3.2",
     "@testing-library/user-event": "^7.1.2",

diff --git a/examples/cypress/package.json b/examples/cypress/package.json
@@ -12,6 +12,7 @@
         "@cypress/browserify-preprocessor": "^3.0.0",
         "@types/node": "14.0.13",
         "cypress": "^4.8.0",
+        "rxjs": "^6.5.2",
         "typescript": "3.9.5"
     },
     "scripts": {

diff --git a/examples/cypress/yarn.lock b/examples/cypress/yarn.lock
@@ -3856,6 +3856,13 @@ rxjs@^6.3.3:
   dependencies:
     tslib "^1.9.0"
 
+rxjs@^6.5.2:
+  version "6.6.3"
+  resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-6.6.3.tgz#8ca84635c4daa900c0d3967a6ee7ac60271ee552"
+  integrity sha512-trsQc+xYYXZ3urjOiJOuCOa5N3jAZ3eiSpQB5hIT8zGlL2QfnHLJ2r7GMkBGuIausdJN1OneaI6gQlsqNHHmZQ==
+  dependencies:
+    tslib "^1.9.0"
+
 safe-buffer@5.1.2, safe-buffer@~5.1.0, safe-buffer@~5.1.1:
   version "5.1.2"
   resolved "https://registry.yarnpkg.com/safe-buffer/-/safe-buffer-5.1.2.tgz#991ec69d296e0313747d59bdfd2b745c35f8828d"

diff --git a/examples/nestjs/package.json b/examples/nestjs/package.json
@@ -14,11 +14,13 @@
     "minimist": "1.2.0",
     "reflect-metadata": "0.1.13",
     "rxjs": "6.5.2",
-    "supertest": "^4.0.2"
+    "supertest": "^4.0.2",
+    "superagent": "~3.8.3"
   },
   "devDependencies": {
     "@bazel/typescript": "^2.2.2",
     "@types/node": "12.6.3",
+    "tslib": "^1.9.0",
     "typescript": "3.5.3"
   },
   "scripts": {

diff --git a/examples/protocol_buffers/package.json b/examples/protocol_buffers/package.json
@@ -15,6 +15,8 @@
     "google-protobuf": "3.11.4",
     "grpc-web": "1.1.0",
     "http-server": "^0.11.1",
+    "jasmine": "2.8.0",
+    "jasmine-core": "2.8.0",
     "karma": "~4.1.0",
     "karma-chrome-launcher": "2.2.0",
     "karma-firefox-launcher": "1.1.0",
@@ -27,6 +29,7 @@
     "requirejs": "2.3.6",
     "rollup": "2.3.4",
     "terser": "4.3.1",
+    "tmp": "0.1.0",
     "typescript": "^3.3.1"
   },
   "scripts": {

diff --git a/examples/react_webpack/package.json b/examples/react_webpack/package.json
@@ -8,6 +8,7 @@
         "@types/react": "^16.9.5",
         "@types/react-dom": "^16.9.1",
         "css-loader": "^3.2.0",
+        "csstype": "^2.2.0",
         "http-server": "^0.11.1",
         "react": "^16.10.2",
         "react-dom": "^16.10.2",

diff --git a/examples/web_testing/package.json b/examples/web_testing/package.json
@@ -4,6 +4,7 @@
     "@bazel/typescript": "^2.2.2",
     "@types/jasmine": "2.8.2",
     "@types/node": "11.11.1",
+    "jasmine-core": "^3.3.0",
     "karma": "~4.1.0",
     "karma-chrome-launcher": "2.2.0",
     "karma-firefox-launcher": "1.1.0",
@@ -12,6 +13,7 @@
     "karma-requirejs": "1.1.0",
     "karma-sourcemap-loader": "0.3.7",
     "requirejs": "2.3.6",
+    "tmp": "0.1.0",
     "typescript": "^3.3.1"
   },
   "scripts": {

diff --git a/examples/web_testing/yarn.lock b/examples/web_testing/yarn.lock
@@ -1064,6 +1064,11 @@ jasmine-core@^3.3:
   resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-3.5.0.tgz#132c23e645af96d85c8bca13c8758b18429fc1e4"
   integrity sha512-nCeAiw37MIMA9w9IXso7bRaLl+c/ef3wnxsoSAlYrzS+Ot0zTG6nU8G/cIfGkqpkjX2wNaIW9RFG0TwIFnG6bA==
 
+jasmine-core@^3.3.0:
+  version "3.6.0"
+  resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-3.6.0.tgz#491f3bb23941799c353ceb7a45b38a950ebc5a20"
+  integrity sha512-8uQYa7zJN8hq9z+g8z1bqCfdC8eoDAeVnM5sfqs7KHv9/ifoJ500m018fpFc7RDaO6SWCLCXwo/wPSNcdYTgcw==
+
 jsonfile@^4.0.0:
   version "4.0.0"
   resolved "https://registry.yarnpkg.com/jsonfile/-/jsonfile-4.0.0.tgz#8771aae0799b64076b76640fca058f9c10e33ecb"

diff --git a/internal/npm_install/generate_build_file.ts b/internal/npm_install/generate_build_file.ts
@@ -596,7 +596,7 @@ export function parsePackage(p: string, dependencies: Set<string> = new Set()):
 
   // set if this is a direct dependency of the root package.json file
   // which is later used to determine the generated rules visibility
-  pkg._directDependency = dependencies.has(pkg._moduleName);
+  pkg._directDependency = dependencies.has(pkg._moduleName) || dependencies.has(pkg._name);
 
   return pkg;
 }

diff --git a/internal/npm_install/index.js b/internal/npm_install/index.js
@@ -356,7 +356,7 @@ function parsePackage(p, dependencies = new Set()) {
     pkg._files = listFiles(p);
     pkg._runfiles = pkg._files.filter((f) => !/[^\x21-\x7E]/.test(f));
     pkg._dependencies = [];
-    pkg._directDependency = dependencies.has(pkg._moduleName);
+    pkg._directDependency = dependencies.has(pkg._moduleName) || dependencies.has(pkg._name);
     return pkg;
 }
 exports.parsePackage = parsePackage;

diff --git a/internal/npm_install/npm_install.bzl b/internal/npm_install/npm_install.bzl
@@ -84,14 +84,12 @@ fine grained npm dependencies.
         doc = "If stdout and stderr should be printed to the terminal.",
     ),
     "strict_visibility": attr.bool(
-        default = False,
+        default = True,
         doc = """Turn on stricter visibility for generated BUILD.bazel files
 
 When enabled, only dependencies within the given `package.json` file are given public visibility.
 All transitive dependencies are given limited visibility, enforcing that all direct dependencies are
 listed in the `package.json` file.
-
-Currently the default is set `False`, but will likely be flipped `True` in rules_nodejs 3.0.0
 """,
     ),
     "symlink_node_modules": attr.bool(

diff --git a/internal/npm_install/test/golden/BUILD.bazel.golden b/internal/npm_install/test/golden/BUILD.bazel.golden
@@ -195,6 +195,44 @@ exports_files([
     "node_modules/jasmine/lib/jasmine.js",
     "node_modules/jasmine/lib/reporters/completion_reporter.js",
     "node_modules/jasmine/lib/reporters/console_reporter.js",
+    "node_modules/jasmine/node_modules/jasmine-core/.editorconfig",
+    "node_modules/jasmine/node_modules/jasmine-core/.github/CONTRIBUTING.md",
+    "node_modules/jasmine/node_modules/jasmine-core/.github/ISSUE_TEMPLATE.md",
+    "node_modules/jasmine/node_modules/jasmine-core/.github/PULL_REQUEST_TEMPLATE.md",
+    "node_modules/jasmine/node_modules/jasmine-core/.ruby-version",
+    "node_modules/jasmine/node_modules/jasmine-core/CODE_OF_CONDUCT.md",
+    "node_modules/jasmine/node_modules/jasmine-core/MANIFEST.in",
+    "node_modules/jasmine/node_modules/jasmine-core/MIT.LICENSE",
+    "node_modules/jasmine/node_modules/jasmine-core/README.md",
+    "node_modules/jasmine/node_modules/jasmine-core/RELEASE.md",
+    "node_modules/jasmine/node_modules/jasmine-core/bower.json",
+    "node_modules/jasmine/node_modules/jasmine-core/images/__init__.pyc",
+    "node_modules/jasmine/node_modules/jasmine-core/images/__pycache__/__init__.cpython-36.pyc",
+    "node_modules/jasmine/node_modules/jasmine-core/images/jasmine-horizontal.png",
+    "node_modules/jasmine/node_modules/jasmine-core/images/jasmine-horizontal.svg",
+    "node_modules/jasmine/node_modules/jasmine-core/images/jasmine_favicon.png",
+    "node_modules/jasmine/node_modules/jasmine-core/jasmine_core.egg-info/PKG-INFO",
+    "node_modules/jasmine/node_modules/jasmine-core/jasmine_core.egg-info/SOURCES.txt",
+    "node_modules/jasmine/node_modules/jasmine-core/jasmine_core.egg-info/dependency_links.txt",
+    "node_modules/jasmine/node_modules/jasmine-core/jasmine_core.egg-info/requires.txt",
+    "node_modules/jasmine/node_modules/jasmine-core/jasmine_core.egg-info/top_level.txt",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/boot.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/node_example/lib/jasmine_examples/Player.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/node_example/lib/jasmine_examples/Song.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/node_example/spec/helpers/jasmine_examples/SpecHelper.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/node_example/spec/jasmine_examples/PlayerSpec.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/spec/PlayerSpec.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/spec/SpecHelper.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/src/Player.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/src/Song.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine-html.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.css",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/json2.js",
+    "node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/node_boot.js",
+    "node_modules/jasmine/node_modules/jasmine-core/package.json",
+    "node_modules/jasmine/node_modules/jasmine-core/requirements.txt",
     "node_modules/jasmine/package.json",
     "node_modules/jasmine/tasks/jasmine.js",
     "node_modules/jasmine-core/.editorconfig",

diff --git a/internal/npm_install/test/golden/jasmine/BUILD.bazel.golden b/internal/npm_install/test/golden/jasmine/BUILD.bazel.golden
@@ -19,6 +19,27 @@ filegroup(
 )
 filegroup(
     name = "jasmine__nested_node_modules",
+    srcs = [
+        "//:node_modules/jasmine/node_modules/jasmine-core/.editorconfig",
+        "//:node_modules/jasmine/node_modules/jasmine-core/.ruby-version",
+        "//:node_modules/jasmine/node_modules/jasmine-core/bower.json",
+        "//:node_modules/jasmine/node_modules/jasmine-core/jasmine_core.egg-info/PKG-INFO",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/boot.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/node_example/lib/jasmine_examples/Player.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/node_example/lib/jasmine_examples/Song.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/node_example/spec/helpers/jasmine_examples/SpecHelper.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/node_example/spec/jasmine_examples/PlayerSpec.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/spec/PlayerSpec.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/spec/SpecHelper.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/src/Player.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/example/src/Song.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine-html.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/jasmine.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/json2.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/lib/jasmine-core/node_boot.js",
+        "//:node_modules/jasmine/node_modules/jasmine-core/package.json",
+    ],
     visibility = ["//:__subpackages__"],
 )
 filegroup(
@@ -50,7 +71,6 @@ js_library(
         "//balanced-match:balanced-match__contents",
         "//concat-map:concat-map__contents",
         "//path-is-absolute:path-is-absolute__contents",
-        "//jasmine-core:jasmine-core__contents",
     ],
 )
 js_library(

diff --git a/package.json b/package.json
@@ -21,6 +21,8 @@
         "@babel/cli": "^7.6.2",
         "@babel/core": "^7.6.2",
         "@babel/preset-env": "^7.6.2",
+        "@babel/parser": "^7.6.2",
+        "@babel/types": "^7.6.2",
         "@bazel/bazelisk": "^1.5.0",
         "@bazel/buildifier": "^3.2.0",
         "@bazel/buildozer": "^3.2.0",
@@ -51,6 +53,7 @@
         "jasmine-core": "~3.4.0",
         "jasmine-reporters": "~2.3.2",
         "jest": "~25.3.0",
+        "jest-cli": "~25.3.0",
         "jest-websocket-mock": "~2.0.2",
         "karma": "~4.1.0",
         "karma-chrome-launcher": "2.2.0",

diff --git a/packages/cypress/test/package.json b/packages/cypress/test/package.json
@@ -6,6 +6,7 @@
         "cypress": "^4.8.0",
         "@cypress/browserify-preprocessor": "^3.0.0",
         "@types/node": "14.0.14",
+        "rxjs": "^6.5.2",
         "typescript": "3.9.5"
     }
 }
diff --git a/packages/cypress/test/yarn.lock b/packages/cypress/test/yarn.lock
@@ -3696,6 +3696,13 @@ rxjs@^6.3.3:
   dependencies:
     tslib "^1.9.0"
 
+rxjs@^6.5.2:
+  version "6.6.3"
+  resolved "https://registry.yarnpkg.com/rxjs/-/rxjs-6.6.3.tgz#8ca84635c4daa900c0d3967a6ee7ac60271ee552"
+  integrity sha512-trsQc+xYYXZ3urjOiJOuCOa5N3jAZ3eiSpQB5hIT8zGlL2QfnHLJ2r7GMkBGuIausdJN1OneaI6gQlsqNHHmZQ==
+  dependencies:
+    tslib "^1.9.0"
+
 safe-buffer@5.1.2, safe-buffer@~5.1.0, safe-buffer@~5.1.1:
   version "5.1.2"
   resolved "https://registry.yarnpkg.com/safe-buffer/-/safe-buffer-5.1.2.tgz#991ec69d296e0313747d59bdfd2b745c35f8828d"

diff --git a/tools/fine_grained_deps_npm/package.json b/tools/fine_grained_deps_npm/package.json
@@ -2,6 +2,7 @@
   "description": "runtime dependencies fine_grained_deps e2e test",
   "devDependencies": {
     "jasmine": "3.3.0",
+    "jasmine-core": "3.3.0",
     "typescript": "3.0.3"
   },
   "dependencies": {

diff --git a/tools/fine_grained_deps_yarn/package.json b/tools/fine_grained_deps_yarn/package.json
@@ -2,6 +2,7 @@
   "description": "runtime dependencies fine_grained_deps e2e test",
   "devDependencies": {
     "jasmine": "3.3.0",
+    "jasmine-core": "3.3.0",
     "typescript": "3.0.3"
   },
   "dependencies": {

diff --git a/tools/fine_grained_deps_yarn/yarn.lock b/tools/fine_grained_deps_yarn/yarn.lock
@@ -702,7 +702,7 @@ isobject@^3.0.0, isobject@^3.0.1:
   resolved "https://registry.yarnpkg.com/isobject/-/isobject-3.0.1.tgz#4e431e92b11a9731636aa1f9c8d1ccbcfdab78df"
   integrity sha1-TkMekrEalzFjaqH5yNHMvP2reN8=
 
-jasmine-core@~3.3.0:
+jasmine-core@3.3.0, jasmine-core@~3.3.0:
   version "3.3.0"
   resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-3.3.0.tgz#dea1cdc634bc93c7e0d4ad27185df30fa971b10e"
   integrity sha512-3/xSmG/d35hf80BEN66Y6g9Ca5l/Isdeg/j6zvbTYlTzeKinzmaTM4p9am5kYqOmE05D7s1t8FGjzdSnbUbceA==

diff --git a/tools/fine_grained_goldens/package.json b/tools/fine_grained_goldens/package.json
@@ -7,6 +7,7 @@
     "@gregmagolan/test-b": "0.0.2",
     "ajv": "5.5.2",
     "jasmine": "3.2.0",
+    "jasmine-core": "3.3.0",
     "rxjs": "6.5.0",
     "unidiff": "0.0.4",
     "zone.js": "^0.9.0"

diff --git a/tools/fine_grained_goldens/yarn.lock b/tools/fine_grained_goldens/yarn.lock
@@ -103,6 +103,11 @@ inherits@2:
   resolved "https://registry.yarnpkg.com/inherits/-/inherits-2.0.3.tgz#633c2c83e3da42a502f52466022480f4208261de"
   integrity sha1-Yzwsg+PaQqUC9SRmAiSA9CCCYd4=
 
+jasmine-core@3.3.0:
+  version "3.3.0"
+  resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-3.3.0.tgz#dea1cdc634bc93c7e0d4ad27185df30fa971b10e"
+  integrity sha512-3/xSmG/d35hf80BEN66Y6g9Ca5l/Isdeg/j6zvbTYlTzeKinzmaTM4p9am5kYqOmE05D7s1t8FGjzdSnbUbceA==
+
 jasmine-core@~3.2.0:
   version "3.2.1"
   resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-3.2.1.tgz#8e4ff5b861603ee83343f2b49eee6a0ffe9650ce"