fix(typescript): don't depend on protobufjs, it's transitive

Fixes an issue exposed by strict npm package visibility
bazel-contrib · Nov 25, 2020 · 1b344db · 1b344db
1 parent 952990b
commit 1b344db
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/packages/typescript/internal/ts_project.bzl b/packages/typescript/internal/ts_project.bzl
@@ -629,19 +629,17 @@ def ts_project_macro(
 
     if supports_workers:
         tsc_worker = "%s_worker" % name
-        protobufjs = (
-            # BEGIN-INTERNAL
-            "@npm" +
-            # END-INTERNAL
-            "//protobufjs"
-        )
         nodejs_binary(
             name = tsc_worker,
             data = [
+                # BEGIN-INTERNAL
+                # Users get this dependency transitively from @bazel/typescript
+                # but that's our own code, so we don't.
+                "@npm//protobufjs",
+                # END-INTERNAL
                 Label("//packages/typescript/internal/worker:worker"),
                 Label(worker_tsc_bin),
                 Label(worker_typescript_module),
-                Label(protobufjs),
                 tsconfig,
             ],
             entry_point = Label("//packages/typescript/internal/worker:worker_adapter"),