Skip to content

Commit

Permalink
fix: fix for node windows cross-compile
Browse files Browse the repository at this point in the history
Fixes issue #909: Toolchains support: Failed to build on Windows for Linux
  • Loading branch information
gregmagolan authored and alexeagle committed Jul 16, 2019
1 parent 960ebee commit 001d945
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/node/node_repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def _prepare_node(repository_ctx):
"""

# TODO: Maybe we want to encode the OS as a specific attribute rather than do it based on naming?
is_windows = is_windows_os(repository_ctx) or "_windows_" in repository_ctx.attr.name
is_windows = "_windows_" in repository_ctx.attr.name
if repository_ctx.attr.vendored_node:
node_exec = "/".join([f for f in [
"../../..",
Expand Down

0 comments on commit 001d945

Please sign in to comment.