Move the KSP and compiler target definitions into rules_kotlin #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
cgruber,
timpeut and
restingbull
as code owners
Merged
|
This is pretty big breaking change, as is. Given that the repository hasn't provided a deprecation warning, I'm not in favor of it as is -- which was why I didn't approve it previously. I think I see a less invasive way to fix the cyclic dependency. |
Bencodes
force-pushed
the
move-the-ksp-and-compiler-target-definitions-into-rules_kotlin
branch
from
824d988
to
bfc2a9c
Compare
restingbull
approved these changes
Sep 8, 2023
nkoroste
added a commit
to nkoroste/rules_kotlin
that referenced
this pull request
Sep 15, 2023
…idanceKotlin_upstream * upstream/master: Move the KSP and compiler target definitions into rules_kotlin (bazelbuild#1014) Avoid running java_common#compile against KSP generated outputs (bazelbuild#990) Update kt_java_stub_template to 6.2.1 (bazelbuild#992) Disable strict deps for Android example (bazelbuild#1013) Group the all_tests jobs together in presubmit.yml (bazelbuild#1008) Add rules_java 6.4.0 (bazelbuild#1010) Update Bazel to 6.3.2 (bazelbuild#1007) Update rules_jvm_external to 5.3 (bazelbuild#1009) Migrate usages of deprecated `JavaInfo` fields (bazelbuild#1005) Remove unnecessary Java runtime dependencies (bazelbuild#1000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some organizational changes to allow easier support for Bzlmod. This may introduce breaking changes for those that are depending on the targets declared directly inside of the
com_github_jetbrains_kotlin/com_github_google_ksprepositories.The new compiler target references can be found under the
@io_bazel_rules_kotlin//kotlin/compiler:...package. We may start to reduce the visibility of these and ask users to eventually start pulling their standard libraries from maven.Details: With Bzlmod we are unable to easily import
kt_macros from within a Bazel repository. To work around this we can shuffle the actualkt_target creation intoio_bazel_rules_kotlininstead of inside the declaredcom_github_jetbrains_kotlin/com_github_google_ksprepositories.