Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extra_outputs on go_proto_compile #3630

Closed
tingilee opened this issue Jul 19, 2023 · 2 comments · Fixed by #3650
Closed

Allow extra_outputs on go_proto_compile #3630

tingilee opened this issue Jul 19, 2023 · 2 comments · Fixed by #3650

Comments

@tingilee
Copy link
Contributor

What version of rules_go are you using?

0.40.0

What version of gazelle are you using?

0.28.0

What version of Bazel are you using?

6.3.0rc1

Does this issue reproduce with the latest releases of all the above?

Yes

What operating system and processor architecture are you using?

MacOS M1 Ventura and Linux AMD

Any other potentially useful information about your toolchain?

What did you do?

See below.

What did you expect to see?

We have a custom plugin to generate enums .pb.go files from .proto files. For example.proto, we expect both
example_dbenum.pb.go and example.pb.go to be generated as Bazel provider outputs. Currently, only files with the same name and .pb.go file extensions are allowed. I'd like to propose adding attributes to allow outputting more w/ custom proto plugins.

What did you see instead?

@fmeum
Copy link
Collaborator

fmeum commented Jul 19, 2023

This sounds useful. Since you have a concrete application in mind, would you be interested in contributing this improvement (with some support from maintainers)?

@tingilee
Copy link
Contributor Author

@fmeum I'd love to. Here's a patch that has worked for our monorepo: #3631 Could you take a look? Happy to add tests and address comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants