go_download_sdk: work around Bazel .tar.gz extraction bug #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 'tar' installed on the system to extract .tar.gz archives instead of Bazel's download_and_extract. Go has at least one test with an invalid unicode file name, and on some configurations (macOS + Docker + some particular file system binding?), this causes an error. Fixes bazelbuild#2771
jayconrod
force-pushed
the
unicode-dl-sdk
branch
from
7a9faf9
to
48989b4
Compare
achew22
reviewed
Mar 5, 2021
| # BUG(#2771): Use a system tool to extract the archive instead of | ||
| # Bazel's implementation. With some configurations (macOS + Docker + | ||
| # some particular file system binding), Bazel's implementation rejects | ||
| # files with invalid unicode names. Go has at least one test case with a |
There was a problem hiding this comment.
Is there a bazel bug to track this?
There was a problem hiding this comment.
Not at the moment. It seemed like a pretty intricate configuration, so I didn't try to reproduce it. I'd rather not report it upstream though without detailed instructions, since it's very unlikely to get fixed.
(Sorry I realize this sounds lazy; it's a consequence of not being able to spend adequate time on this).
There was a problem hiding this comment.
I think the Bazel bug is bazelbuild/bazel#12986
achew22
approved these changes
Mar 5, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'tar' installed on the system to extract .tar.gz archives instead
of Bazel's download_and_extract. Go has at least one test with an
invalid unicode file name, and on some configurations (macOS with Docker
and some particular file system binding?), this causes an error.
Fixes #2771