entrypoint / launcher in nodejs_image isn't respected

[martaver]

🐞 bug report

Affected Rule

The problem is with nodejs_image.

Is this a regression?

I'm not sure, I've only recently started with bazel.

Description

I am trying to run a script prior to executing the nodejs binary, in order to initialise some system dependencies that I installed on a custom base image.

The 'dockerfile' way to do this is to use an ENTRYPOINT script described here:
https://stackoverflow.com/questions/41512237/how-to-execute-a-shell-command-before-the-entrypoint-via-the-dockerfile

...and then call node with CMD

However, nodejs_image seems to use CMD for args, and ENTRYPOINT for the nodejs binary.

Also when I provide it with an alternative entrypoint or a launcher, the resulting docker image ignores both, and the ENTRYPOINT remains stuck at: "/app/path/to/myapp"

The net result of this is that I can't configure 'launcher scripts' and use nodejs_image at the same time.

🔬 Minimal Reproduction

Clone:
https://github.com/cleric-sh/cleric-bazel

Run:

bazelisk run //services/messenger:image

Then:

docker image inspect bazel/services/messenger:image

Not that the launcher defined in images/chrome/BUILD:34 is left out.

🌍 Your Environment

Operating System:

  
OSX 11.2.3
  

Output of bazel version:

  
Bazelisk version: v1.7.5
Build label: 4.0.0
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Jan 21 07:38:50 2021 (1611214730)
Build timestamp: 1611214730
Build timestamp as int: 1611214730
  

Rules_docker version:

  
v0.16.0
  

Anything else relevant?

[github-actions]

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

[martaver]

This has been implemented in https://github.com/bazelbuild/rules_docker/tree/v0.18.0