Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra_target #6774

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Add extra_target #6774

merged 1 commit into from
Sep 23, 2024

Conversation

luyi326
Copy link
Contributor

@luyi326 luyi326 commented Sep 21, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: 6659

Description of this change

For CPP aspect intellij_info , check additional_compiler_inputs field and use that in swtring expansion as well

Copy link

google-cla bot commented Sep 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@LeFrosch
Copy link
Collaborator

@luyi326 Thanks, for the PR. Looks good to me. Please just sign the CLA and we can probably merge this.

@LeFrosch LeFrosch self-assigned this Sep 23, 2024
@luyi326
Copy link
Contributor Author

luyi326 commented Sep 23, 2024

Fixed commit email! @LeFrosch

@LeFrosch LeFrosch merged commit 4006a96 into bazelbuild:master Sep 23, 2024
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Sep 23, 2024
@LeFrosch
Copy link
Collaborator

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants