Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6664] Default disable ExternalWorkspaceDataProvider #6704

Conversation

mtoader
Copy link
Contributor

@mtoader mtoader commented Sep 1, 2024

Some blaze workspaces with blaze > MINIMUM_BLAZE_VERSION (7.1.0
have explicitly disabled bzlmod support and this causes
blaze mod to fail (which fails the whole sync).

disable the Provider until a more reliable opt-in is found.

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Discussion thread for this change

Issue number: 6703, 6664 ( #6703, #6664)

Description of this change

Disable ExternalWorkspaceDataProvider until a more reliable opt-in mechanism is chosen.

Some blaze workspaces with blaze > MINIMUM_BLAZE_VERSION
have explicitly disabled bzlmod support and this causes blaze mod to fail.

 Some blaze workspaces with blaze > MINIMUM_BLAZE_VERSION (7.1.0
 have explicitly disabled bzlmod support and this causes
 `blaze mod` to fail (which fails the whole sync).

  disable the Provider until a more reliable opt-in is found.
@tpasternak tpasternak merged commit 9343e7e into bazelbuild:master Sep 2, 2024
8 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Sep 2, 2024
@tpasternak
Copy link
Collaborator

@mai93 @sgowroji beta channel is broken, we need a hotfix for this

@mtoader mtoader deleted the mtoader/disable-external-workspace-data-provider branch September 3, 2024 16:30
@mai93
Copy link
Collaborator

mai93 commented Sep 3, 2024

The release currently in beta v2024.08.27 only contains the first commit from this project, it does not have base/src/com/google/idea/blaze/base/model/ExternalWorkspaceDataProvider.java, is a hotfix still needed?

@mtoader
Copy link
Contributor Author

mtoader commented Sep 3, 2024

If the provider is not in, hotfix is not needed.

@tpasternak
Copy link
Collaborator

Right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants