Added build folder action #6615

kitbuilder587 · 2024-08-06T14:22:57Z

Checklist

I have filed an issue about this change and discussed potential changes with the maintainers.
I have received the approval from the maintainers to make this change.
This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #6613

Description of this change

Added action to compile folder

You can't build folder, you can only sync it. Building could be much faster. For example in our project sync of entire folder takes x2 time more than build. I've already added this feature to my local Bazel plugin. I've added button to compile directory below the partial sync. It would be great if we can contribute it

…/kitbuilder587/intellij into zajdelovm-feature-request-branch

tpasternak · 2024-08-09T10:52:36Z

base/src/com/google/idea/blaze/base/actions/CompileFolderAction.java

@@ -0,0 +1,73 @@
+/*
+ * Copyright 2016 The Bazel Authors. All rights reserved.


tpasternak · 2024-08-09T10:54:05Z

base/src/com/google/idea/blaze/base/sync/sharding/BlazeBuildTargetSharder.java

-import java.util.Map;
-import java.util.Objects;
+
+import java.util.*;


We prefer to aviod wildcard imports

tpasternak · 2024-08-09T11:29:51Z

base/src/com/google/idea/blaze/base/sync/sharding/BlazeBuildTargetSharder.java

@@ -111,6 +109,9 @@ private enum ShardingApproach {

  private static ShardingApproach getShardingApproach(
      SyncStrategy parallelStrategy, ProjectViewSet viewSet) {
+    if (parallelStrategy == SyncStrategy.SERIAL_NOT_EXPAND) {


So this overrides the shard_sync setting in the PV, how about just keeping the old behavior here?

The issue here is that compile folder with shard_sync=true takes sooo much more time. For example, one of our project's folder compiles in 17s with shard_sync=true and in 1s with shard_sync=false. The main reason why we added this button was that sync time was very slow, and we wanted to speed up compile errors check. Ordinary user won't set shard_sync to false without any reason. We can add another setting to set shard_sync for build folder action, but I think in cases when OOM happens, you can just use Partial Sync instead

Oh, that's a good point. Btw what do you think about setting the default PV in tools/intellij/.managed.bazelproject with shard_sync: true?.

Example here https://github.com/bazelbuild/bazel/blob/master/tools/intellij/.managed.bazelproject

Personally, I think It's a good idea, but I don't have a lot of knowledge about how often people want to use shard_sync=true. In our project we use it quite rarely, but I can't expand my PV on all users of the plugin.
Should I create another PR here or we can stay on current realization or may be another ideas?

@LeFrosch what do you think about it?

Oh, actually if I am not mistaken, shard-sync=false by default. We can delete this property in enum

But anyway logically it would be better if shard-sync won't affect build. Oftenshard-sync=true is used for full sync of project if OOM happens. shard-sync=true will affect the build folder speed. (17s and 1s is big diff) I don't think that it will be used for the whole project often. With shard-sync=true build folder action is useless, because the diff between build and sync time isn't big. I think SERIAL_NOT_EXPAND anyway will be better

Okay, but I can't guarantee it will be permanent. If it turns out to be misleading, we’ll adjust it to align with the shard_sync setting.

tpasternak · 2024-08-09T11:51:00Z

base/src/com/google/idea/blaze/base/actions/CompileFolderAction.java

+    ActionPresentationHelper.of(e)
+            .disableIf(virtualFile == null)
+            .disableIf(!virtualFile.isDirectory())
+            .setText(virtualFile.getName() + "/...:all")


No the text is "folder/...alll", can we change it to "Compile folder/...all"?

Project Status API integration with bazel for CLion (bazelbuild#6585) Integration with the new Project Status Widget that is added in CLion 242. Implement py imports handling (bazelbuild#6606) Some `py_...` rules allow for an `imports` attribute. The attribute allows control over how the Python files are vended in terms of modules. This change will mean that the use of the `imports` attribute in Bazel targets is reflected in how the modules are auto-completed and recognized in the IDE. Update CompileCorrespondingBuildFilesAction.java button name change Update CompileCorrespondingBuildFilesAction.java Added build folder action Update BlazeBuildService.java review remarks fix

…/kitbuilder587/intellij into zajdelovm-feature-request-branch

kitbuilder587 requested review from mai93, tpasternak and agluszak as code owners August 6, 2024 14:22

github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Aug 6, 2024

Merge branch 'master' into zajdelovm-feature-request-branch

4e79303

github-actions bot assigned mai93, tpasternak and ujohnny Aug 6, 2024

kitbuilder587 added 7 commits August 6, 2024 19:47

Update CompileCorrespondingBuildFilesAction.java

c1cacd1

Merge branch 'zajdelovm-feature-request-branch' of https://github.com…

c4f6938

…/kitbuilder587/intellij into zajdelovm-feature-request-branch

Update CompileCorrespondingBuildFilesAction.java

4bd7d29

button name change

f3e1697

Update CompileCorrespondingBuildFilesAction.java

8bab9b4

Added build folder action

cf0bb22

Update BlazeBuildService.java

1ab1234

tpasternak reviewed Aug 9, 2024

View reviewed changes

kitbuilder587 added 7 commits August 10, 2024 15:36

review remarks fix

86df84e

Merge branch 'zajdelovm-feature-request-branch' of https://github.com…

925f9c7

…/kitbuilder587/intellij into zajdelovm-feature-request-branch

SERIAL_NOT_EXPAND deleted

8562252

Update BlazeBuildTargetSharder.java

a59c674

serial not expand

83d41eb

Merge branch 'zajdelovm-feature-request-branch' of https://github.com…

f6f9515

…/kitbuilder587/intellij into zajdelovm-feature-request-branch

kitbuilder587 force-pushed the zajdelovm-feature-request-branch branch from f6f9515 to 9f87422 Compare August 15, 2024 07:12

revert

ec81777

tpasternak approved these changes Aug 16, 2024

View reviewed changes

tpasternak merged commit fcc25cd into bazelbuild:master Aug 16, 2024
6 checks passed

github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Aug 16, 2024

tpasternak mentioned this pull request Aug 19, 2024

Add build folder action to plugin #6613

Closed

mai93 mentioned this pull request Aug 27, 2024

Update changelog for v2024.08.27 release #6660

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added build folder action #6615

Added build folder action #6615

kitbuilder587 commented Aug 6, 2024 •

edited

Loading

tpasternak Aug 9, 2024

tpasternak Aug 9, 2024

tpasternak Aug 9, 2024

kitbuilder587 Aug 10, 2024 •

edited

Loading

tpasternak Aug 12, 2024

kitbuilder587 Aug 12, 2024 •

edited

Loading

tpasternak Aug 12, 2024

kitbuilder587 Aug 15, 2024 •

edited

Loading

kitbuilder587 Aug 15, 2024 •

edited

Loading

tpasternak Aug 16, 2024

tpasternak Aug 9, 2024

		@@ -0,0 +1,73 @@
		/*
		* Copyright 2016 The Bazel Authors. All rights reserved.

Added build folder action #6615

Added build folder action #6615

Conversation

kitbuilder587 commented Aug 6, 2024 • edited Loading

Checklist

Discussion thread for this change

Description of this change

tpasternak Aug 9, 2024

Choose a reason for hiding this comment

tpasternak Aug 9, 2024

Choose a reason for hiding this comment

tpasternak Aug 9, 2024

Choose a reason for hiding this comment

kitbuilder587 Aug 10, 2024 • edited Loading

Choose a reason for hiding this comment

tpasternak Aug 12, 2024

Choose a reason for hiding this comment

kitbuilder587 Aug 12, 2024 • edited Loading

Choose a reason for hiding this comment

tpasternak Aug 12, 2024

Choose a reason for hiding this comment

kitbuilder587 Aug 15, 2024 • edited Loading

Choose a reason for hiding this comment

kitbuilder587 Aug 15, 2024 • edited Loading

Choose a reason for hiding this comment

tpasternak Aug 16, 2024

Choose a reason for hiding this comment

tpasternak Aug 9, 2024

Choose a reason for hiding this comment

kitbuilder587 commented Aug 6, 2024 •

edited

Loading

kitbuilder587 Aug 10, 2024 •

edited

Loading

kitbuilder587 Aug 12, 2024 •

edited

Loading

kitbuilder587 Aug 15, 2024 •

edited

Loading

kitbuilder587 Aug 15, 2024 •

edited

Loading