Project Status API integration with bazel for CLion #6585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
|
Other than that, looks good to me and seems to be working as expected. |
LeFrosch
reviewed
Jul 22, 2024
clwb/sdkcompat/v242/com/google/idea/blaze/clwb/CLionNotificationProvider.java
Outdated
Show resolved
Hide resolved
clwb/sdkcompat/vOlder/com.google.idea.blaze.clwb/BazelCNotificationProvider.java
Outdated
Show resolved
Hide resolved
clwb/sdkcompat/vOlder/com.google.idea.blaze.clwb/BazelCNotificationProvider.java
Outdated
Show resolved
Hide resolved
clwb/sdkcompat/v242/com/google/idea/blaze/clwb/CLionNotificationProvider.java
Show resolved
Hide resolved
ujohnny
reviewed
Jul 23, 2024
clwb/sdkcompat/v242/com/google/idea/blaze/clwb/CLionNotificationProvider.java
Outdated
Show resolved
Hide resolved
|
@TomatorCZ could you please update the PR title and description to make it more detailed regarding the scope of the change? |
TomatorCZ
force-pushed
the
Tomas.Husak/dev/PSWAPI
branch
from
7e493bb
to
2ffac23
Compare
TomatorCZ
changed the title
TomatorCZ
changed the title
TomatorCZ
force-pushed
the
Tomas.Husak/dev/PSWAPI
branch
from
2ffac23
to
9225170
Compare
LeFrosch
reviewed
Jul 29, 2024
Comment on lines
+25
to
+28
| /** | ||
| * Provide notification for C-family files temporarily until moving to new CLion project status | ||
| * api. | ||
| */ |
There was a problem hiding this comment.
I guess we can drop this comment, no longer temporarily.
ujohnny
approved these changes
Aug 1, 2024
github-actions
bot
removed
the
awaiting-review
kitbuilder587
added a commit
to kitbuilder587/intellij
that referenced
this pull request
Aug 15, 2024
Project Status API integration with bazel for CLion (bazelbuild#6585) Integration with the new Project Status Widget that is added in CLion 242. Implement py imports handling (bazelbuild#6606) Some `py_...` rules allow for an `imports` attribute. The attribute allows control over how the Python files are vended in terms of modules. This change will mean that the use of the `imports` attribute in Bazel targets is reflected in how the modules are auto-completed and recognized in the IDE. Update CompileCorrespondingBuildFilesAction.java button name change Update CompileCorrespondingBuildFilesAction.java Added build folder action Update BlazeBuildService.java review remarks fix
tpasternak
pushed a commit
that referenced
this pull request
Aug 16, 2024
* Added build folder action You can't build folder, you can only sync it. Building could be much faster. For example in our project sync of entire folder takes x2 time more than build. I've already added this feature to my local Bazel plugin. I've added button to compile directory below the partial sync. It would be great if we can contribute it * Update CompileCorrespondingBuildFilesAction.java * Update CompileCorrespondingBuildFilesAction.java * button name change * Update CompileCorrespondingBuildFilesAction.java * Added build folder action * Update BlazeBuildService.java * review remarks fix * Update CompileCorrespondingBuildFilesAction.java Project Status API integration with bazel for CLion (#6585) Integration with the new Project Status Widget that is added in CLion 242. Implement py imports handling (#6606) Some `py_...` rules allow for an `imports` attribute. The attribute allows control over how the Python files are vended in terms of modules. This change will mean that the use of the `imports` attribute in Bazel targets is reflected in how the modules are auto-completed and recognized in the IDE. Update CompileCorrespondingBuildFilesAction.java button name change Update CompileCorrespondingBuildFilesAction.java Added build folder action Update BlazeBuildService.java review remarks fix * SERIAL_NOT_EXPAND deleted * Update BlazeBuildTargetSharder.java * serial not expand * revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of this change
Currently(>=242), CLion shows dedicated widget/yellow banner for all collected problems regarding project settings and offers their fixes in a fix menu. Since the plugin already has a project notification which allows to import bazel project (See
BazelCNotificationProvider), we want to use the API to stay align with CLion UX. The following changes were made:BazelCNotificationProviderto clwb/sdkcompatBazelCNotificationProviderto use Project Status API in clwb/sdkcompat/v242CMakeNotificationFiltertoclwb/sdkcompatBazelNotificationProviderfor CLion