CLion MSVC Support #6500
Merged
CLion MSVC Support #6500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFrosch
force-pushed
the
Daniel.Brauner/windows
branch
5 times, most recently
from
352c32e
to
f28e1c6
Compare
LeFrosch
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
LeFrosch
force-pushed
the
Daniel.Brauner/windows
branch
2 times, most recently
from
eaa77f3
to
b374efb
Compare
ujohnny
requested changes
Jul 22, 2024
| @@ -184,6 +189,35 @@ private ImmutableMap<TargetKey, BlazeCTargetInfoService.TargetInfo> calculatePer | |||
| return infoMap.build(); | |||
| } | |||
|
|
|||
| private CompilerSpecificSwitchBuilder selectSwitchBuilder( | |||
| return new GCCSwitchBuilder(); | ||
| } | ||
|
|
||
| private CidrCompilerSwitches buildSwitchBuilder( |
ujohnny
force-pushed
the
Daniel.Brauner/windows
branch
from
959da51
to
6e7415a
Compare
ujohnny
approved these changes
Jul 24, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #6451
Description of this change
Fixes windows specific issues and adds support for MSVC. Since, the
MSVCCompilerToVersionCacheServiceis only available since 231 all earlier versions are not supported.Limitations: