-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could please use Go modules to manage dependencies? #961
Comments
I have attempted to file a PR for this but build failed #959 |
So the idea of Go modules is when you make a breaking API change, you increase the major version. So I think all we need here is a go.mod and go.sum file to make this work? |
Yeah, the idea is to make builds reproducible for downstream that does not use Bazel. |
You guys should release a new version so that downstream (eg. Homebrew) can use the new version commit to re-enable, build and install |
I've just released 4.0.1 |
@vladmos Cool! |
The release of Go v1.16, which sets
GO111MODULE
env toon
by default (ref: https://golang.org/doc/go1.16#go-command), leads to build failure of Homebrew formulabuildifier
andbuildozer
. Thus they disable them for now in PR Homebrew/homebrew-core#71330If to use Go modules to manage dependencies, it'll be great for downstreams (eg. Homebrew) to build and install them.
The text was updated successfully, but these errors were encountered: