Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could please use Go modules to manage dependencies? #961

Closed
Loyalsoldier opened this issue Feb 18, 2021 · 6 comments
Closed

Could please use Go modules to manage dependencies? #961

Loyalsoldier opened this issue Feb 18, 2021 · 6 comments

Comments

@Loyalsoldier
Copy link

The release of Go v1.16, which sets GO111MODULE env to on by default (ref: https://golang.org/doc/go1.16#go-command), leads to build failure of Homebrew formula buildifier and buildozer. Thus they disable them for now in PR Homebrew/homebrew-core#71330

If to use Go modules to manage dependencies, it'll be great for downstreams (eg. Homebrew) to build and install them.

@Loyalsoldier
Copy link
Author

I have attempted to file a PR for this but build failed #959

@pmbethe09
Copy link
Member

So the idea of Go modules is when you make a breaking API change, you increase the major version.
At this time, we have not made any breaking changes that I am aware of, so even though we are version 4.0.0 it isn't really a Go 'v4' implying a 3rd breaking API change.

So I think all we need here is a go.mod and go.sum file to make this work?

@Loyalsoldier
Copy link
Author

Loyalsoldier commented Feb 27, 2021

Yeah, the idea is to make builds reproducible for downstream that does not use Bazel.

@Loyalsoldier
Copy link
Author

You guys should release a new version so that downstream (eg. Homebrew) can use the new version commit to re-enable, build and install buildifier and buildozer.

Homebrew/homebrew-core#71330 (comment)

@vladmos
Copy link
Member

vladmos commented Mar 1, 2021

I've just released 4.0.1

@Loyalsoldier
Copy link
Author

@vladmos Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants