Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message in case the user forgot to specify managed directory for the repository #8293

Closed
irengrig opened this issue May 10, 2019 · 3 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request

Comments

@irengrig
Copy link
Contributor

Currently, if one forgets to mention the managed directory in the workspace function, the following error is shown to user:

no such package '@repo//package': BUILD file not found on package path and referenced by

This message can be improved as we can "guess" that the package missing under the external repository is probably in generated code, and therefore it should be marked as managed directory

Context: managed directories: #8201

@irengrig irengrig self-assigned this May 10, 2019
@irengrig irengrig added P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels May 10, 2019
@dslomov
Copy link
Contributor

dslomov commented May 10, 2019

Maybe the repository rule that requires managed directories should check for their existence and error out then?

@irengrig
Copy link
Contributor Author

The problem is that in the situation, when the user forgot to specify managed directories, the repository rule is not called, so it can not do anything. (And managed directories settings are not exposed to Starlark).

@meisterT meisterT added untriaged and removed P1 I'll work on this now. (Assignee required) labels May 12, 2020
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@philwo philwo added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request and removed untriaged labels Feb 8, 2021
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
@sgowroji sgowroji added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 16, 2023
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

@sgowroji sgowroji closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants