Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_test rule to address --incompatible_disallow_struct_provider_syntax flag #7842

Closed
alex1545 opened this issue Mar 26, 2019 · 2 comments
Closed
Assignees
Labels
P1 I'll work on this now. (Assignee required) type: bug

Comments

@alex1545
Copy link

Description of the problem / feature request:

In rules_docker we are addressing issue #7347 to only return a list of providers from all rule implementation functions (PR). We import the file_test rule from this project that still returns a struct, which makes our CI fail when running with the --incompatible_disallow_struct_provider_syntax flag.

Do you have any timelines as of when you plan to address issue #7347 in this project or maybe for the file_test rule?

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Run any file_testtarget with the --incompatible_disallow_struct_provider_syntax flag.

What's the output of bazel info release?

0.23.2

@laurentlb laurentlb added type: bug P1 I'll work on this now. (Assignee required) and removed untriaged labels Mar 27, 2019
@laurentlb
Copy link
Contributor

@c-parsons fixed the file test_rules.bzl.

Chris, shall we get rid of test_rules.bzl? Any reason not to use Skylib?

@katre
Copy link
Member

katre commented May 13, 2020

Closed for lack of activity. Please ping the reviewers to reopen if this is still a problem.

@katre katre closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) type: bug
Projects
None yet
Development

No branches or pull requests

5 participants