Release 0.19 - October 2018

[laurentlb]

@katre Can you manage the 0.19 release?

Target RC date: October 1st

[katre]

Yes, I can handle it.

[katre]

Looks like last night's downstream projects run is fairly solid: the majority of the errors are build machine configuration related.

Using ac88041 as the baseline.

[katre]

Pushed release 0.19.0rc1 - baseline ac88041

[katre]

Release announcement sent, downstream tests starting.

[katre]

Declaring #6283 a release blocker for 0.19.0.

[katre]

#6283 is fixed by 20bfdc6, will cherrypick that into rc2 today.

[katre]

Created rc2:

scripts/release/release.sh create --force_rc=2 0.19.0 ac880418885061d1039ad6b3d8c28949782e02d6 20bfdc67dc1fc32ffebbda7088ba49ee17e3e182

[katre]

The "No JDK" platform is failing all tests for rc2, creating RC3 cherrypicking in 9bc3b20 to try and handle this.

[katre]

Command:

scripts/release/release.sh create --force_rc=3 0.19.0 ac880418885061d1039ad6b3d8c28949782e02d6 9bc3b20053a8b99bf2c4a31323a7f96fabb9f1ec 20bfdc67dc1fc32ffebbda7088ba49ee17e3e182

[katre]

No, everything on the "no JDK" host is still failing:

ERROR: /var/lib/buildkite-agent/builds/buildkite-worker-ubuntu1804-nojava-9ssq-1/bazel/bazel-bazel/src/main/java/com/google/devtools/build/lib/BUILD:1569:1: every rule of type java_library implicitly depends upon the target '@openjdk_linux_archive//:runtime', but this target could not be found because of: no such package '@openjdk_linux_archive//': The repository could not be resolved

[katre]

Also need to cherrypick 54c2572 (this will fix bazelbuild/continuous-integration#341)

[katre]

RC4 is out (and has been since Thursday, sorry): https://releases.bazel.build/0.19.0/rc4/index.html

[petemounce]

rc1-4 pushed to chocolatey

[katre]

Last RC has all green tests: https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/491

[irengrig]

Hi @katre, please cherry pick the fix of this issue: #6292
Looks like it blocks the users.
Thank you!

[dslomov]

Is #6292 a regression since 0.18? If not, the fix should not be cherrypicked.

[katre]

Given that 0.18 isn't released, can anything be a regression since 0.18?

According to #6292, the cause is 4e42e17, which went in on July 9.

The fix (914b4ce) looks low-risk.

[dslomov]

So it is in 0.17 and not cherrypicked into 0.18.
Our policy is that we do not cherry-pick non-regressions, so let's not do it.

[irengrig]

Ok, could you hint me what better comment on the issue in response to the user's request..

[davido]

I'm getting this suspicious warning when building gerrit:

INFO: From SkylarkAction external/bazel_tools/tools/jdk/platformclasspath.jar [for host]:
warning: could not find a JDK 8 bootclasspath in external/embedded_jdk, falling back to --release

I don't see this warning when building from Bazel@HEAD (72ef398).

Used Bazel version:

$ bazel version
Build label: 0.19.0rc4

[hlopko]

I'm not sure what the process is, so just to be sure I'll say that I'll perform an incompatible change flip (#6380) in 0.19. I already pinged 0.18 about this. Adding here as well as FYI.

[meteorcloudy]

Please cherry-pick 914b4ce to fix #6292, it is a regression since 0.17.X, not in 0.16.0

[meteorcloudy]

So in my opinion, #6292 is a regression from 0.16.0 to 0.17.0, but only got discovered after releasing 0.17.0, I believe it is qualified to be cherry-picked into 0.19.0.

[dslomov]

Who is blocked by #6292? Why we need it chery-picked into 0.19 (as opposed to waiting for 0.20?)

[hlopko]

Do we ask that with regressions?

[dslomov]

We do. But also, this is not a regression - it has been in two releases already.

[katre]

No blockers reported, going ahead with the release.

[katre]

Release 0.19.1 is ready. @petemounce and @vbatts, can you also update?

[vbatts]

On 12/11/18 11:18 -0500, katre wrote: Release 0.19.1 is ready. ***@***.*** and ***@***.***, can you also update?

https://copr.fedorainfracloud.org/coprs/vbatts/bazel/build/823004/

[petemounce]

Published to chocolatey. I noticed #6665 / #6662 were opened however :(

[katre]

Yes, this is unfortunate, I think we'll need a 0.19.2 as soon as I can figure out the solutions.

[nlopezgi]

also mentioned in the issues, I think the problem is 0.19.1 did not include 6bc4528

[katre]

I am going to create 0.19.2 with f7e5aef and 6bc4528. @nlopezgi please advise on how I can test for issue #6665 before I do the actual release.

[katre]

Release 0.19.2rc1:

./scripts/release/release.sh create create --force_rc=1 0.19.2 0.19.1 6bc452874ddff69cbf7f66186238032283f1195f f7e5aef145c33968f658eb2260e25630dc41cc67

[katre]

RC1 testing: https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/586#_
The test failures in singlejar have two causes:

• src/tools/singlejar:output_jar_simple_test references the target @local_jdk//:jdk-default, which may have existed when that commit was submitted but does not exist now; and
• Tests for singlejar were not run until d571354, last week.

Given the massive changes in src/tools/singlejar/BUILD since the version in the release-0.19.2 branch, I don't think a fix is feasible.

The other error, rules_apple, fails in //test:ios_imessage_test.device. I am investigating.

Further, a user has reported the following error building their project:

ERROR: /usr/local/google/home/minors/.cache/bazel/_bazel_minors/86021668b1f881516e569ba9a9189b20/external/local_config_cc/BUILD:57:1: in cc_toolchain rule @local_config_cc//:cc-compiler-k8: Error while selecting cc_toolchain: Toolchain identifier 'local' was not found, valid identifiers are [stub_armeabi-v7a, local_linux, local_darwin, local_freebsd, local_windows_mingw, local_windows_msys64_mingw64, local_windows_clang, local_windows_msys64, vc_14_0_x64]
ERROR: Analysis of target '//REDACTED:REDACTED' failed; build aborted: Analysis of target '@local_config_cc//:cc-compiler-k8' failed; build aborted
INFO: Elapsed time: 0.246s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets configured)

Given these, I am not publishing this RC, and will track down the errors to try and find a fix.

[katre]

Filed bazelbuild/rules_apple#245 for the rules_apple issue.

[katre]

It's a known flake.

[katre]

Considering cherrypicking 683c302 to fix #6662 and #6665, waiting to see if it addresses the reported problems.

[katre]

Testing looks good, I am going to go ahead and create 0.19.2rc2 with this additional cherrypick so it can be tested.

[katre]

Created rc2:

./scripts/release/release.sh create --force_rc=2 0.19.2 0.19.1 6bc452874ddff69cbf7f66186238032283f1195f f7e5aef145c33968f658eb2260e25630dc41cc67 683c302129b66a8999f986be5ae7e642707e978c

[katre]

RC2 shows serious errors in cc-rules-tests (https://storage.googleapis.com/bazel-buildkite-artifacts/e813c7da-880e-4b59-b805-c14f30289cbd/src/test/java/com/google/devtools/build/lib/rules/cpp/cpp-rules-tests/attempt_1.log)

[katre]

@scentini has found the relevant commits that should fix CcToolchainTests. One applies many changes (b91d830), the second rolls most of them back (00ac609), but should leave the tests fixed. Trying that today, hopefully can get RC3 out. (Might also need fc7e740, which comes between the two.)

[katre]

Yes, it does need fc7e740.

[katre]

No, that's not enough. This is turning into a lot of cherrypicks for one test, looking into alternatives

[katre]

Since the error is known and is the result of a mis-configured test, I'm ignoring it and releasing RC2 anyway.

[katre]

Sent announcement about 0.19.2RC2.

[sergiocampama]

will 0.19.1 hit homebrew?

[katre]

It is supposed to, looks like the PR (bazelbuild/homebrew-tap#17) failed in CI due to xcode versions, so I filed an issue (bazelbuild/homebrew-tap#18) which hasn't been addressed yet, I'll poke people, but 0.19.2 should be released on Mondayish.

[katre]

Planning to release 0.19.2 today, since I haven't seen any further blockers reported.

[katre]

Bazel release 0.19.2 is now available.

@petemounce and @vbatts, can you please update your packages?

I will update Homebrew now.

[katre]

Bazel's Homebrew-tap project updated: bazelbuild/homebrew-tap@8e0ab3d

[vbatts]

On 19/11/18 11:37 -0500, katre wrote: Bazel release 0.19.2 is now available. ***@***.*** and ***@***.***, can you please update your packages?

https://copr.fedorainfracloud.org/coprs/vbatts/bazel/build/826621/

[petemounce]

0.19.2 is available on chocolatey.

[katre]

Thanks! Closing issue now that release is complete.