Ignore usages of ignored flag aliases instead of failing #25125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `.bazelrc` contains: ``` common --flag_alias=my_flag=//:my_flag common --my_flag=value ``` commands that don't support Starlark flags no longer fails with: ``` ERROR: --my_flag=value :: Unrecognized option: --my_flag=value ```
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-Configurability
|
Noting for the record that this is consistent with |
gregestren
reviewed
Jan 30, 2025
| add_to_bazelrc "common --drink=coffee" | ||
| write_build_setting_bzl | ||
|
|
||
| # canonicalize-flags does not see the common flag in .bazelrc. |
There was a problem hiding this comment.
What does this comment mean? I thought canonicalize-flags does see common settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
.bazelrccontains:commands that don't support Starlark flags no longer fails with:
Fixes #25116