Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--ios_multi_cpus defaults to x86_64 on M1 Macs #14284

Closed
brentleyjones opened this issue Nov 16, 2021 · 6 comments · Fixed by bazelbuild/rules_apple#1154
Closed

--ios_multi_cpus defaults to x86_64 on M1 Macs #14284

brentleyjones opened this issue Nov 16, 2021 · 6 comments · Fixed by bazelbuild/rules_apple#1154

Comments

@brentleyjones
Copy link
Contributor

Description of the problem / feature request:

--ios_multi_cpus should default to sim_arm64 on M1 Macs, but still defaults to x86_64.

Feature requests: what underlying problem are you trying to solve with this feature?

M1 Mac users shouldn't have to override --ios_multi_cpus to get the proper default.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Build an ios_application target on an M1 Mac, see that the architecture is for the x86_64 simulator.

I think that this might be the issue:

def _ios_cpu_from_cpu(cpu):
if cpu.startswith(IOS_CPU_PREFIX):
return cpu[len(IOS_CPU_PREFIX):]
return DEFAULT_IOS_CPU

d7628e1 changed the default in one place already.

What operating system are you running Bazel on?

macOS 11.6.1 (arm64)

What's the output of bazel info release?

release 6.0.0-pre.20211101.2

@brentleyjones
Copy link
Contributor Author

brentleyjones commented Nov 16, 2021

Probably can reopen #13873 instead? Not sure if it's a different issue.

@keith
Copy link
Member

keith commented Nov 16, 2021

That Pr Was merged so probably want a new one instead

@keith
Copy link
Member

keith commented Nov 17, 2021

We think now this is likely related to this transition bazelbuild/rules_apple#1154

@gregestren
Copy link
Contributor

If bazelbuild/rules_apple#1154 fixes this, can we mark as such in the description to close this issue when ready?

@brentleyjones
Copy link
Contributor Author

Done. When it's merged it will close this.

@keith
Copy link
Member

keith commented Nov 29, 2021

Didn't work because of ACL, but that's merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants