-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel head breaks RBE tests #13321
Comments
Can you please be more specific. What is broken, what needs to be cherry picked? Is it broken in 4.0? |
cc @philwo |
@coeuvre Can you confirm that this is fine and the needed cherrypicks are present? |
Yes, the needed cherrypicks are included. |
Just to verify, I was clicking on the cherrypicks and the last one was a PR (#13339). Unlike the other entries (e.g., 4efeac9), I didn't see a label indicating this was included in 5.0.0-pre.20210708.4 (when I clicked on specific commits in https://github.com/bazelbuild/bazel/pull/13339/commits), I noticed there was a warning banner saying certain commits weren't included in any release (e.g., 6636dc2)? I am probably using github wrong (I don't have much experience with it), but just wanted to double check the last set of commits really is included in the release? |
@sethkoehler Because of the degree of divergence between 4.2.0 and 5.0.0-pre, the commits require changes to merge cleanly. This changes the commit id and causes git to report that it is only on the release branch. These are still cherrypicked commits from the master branch on bazelbuild/bazel. Some commits are also fixes for specific release blockers and may not yet be in a released version of Bazel. |
Ok, glad to hear all is well, thank you for confirming those commits are indeed in the upcoming 5.0.0 release! |
This is a tracking bug to ensure that all the fixes are cherrypicked into the release.
The text was updated successfully, but these errors were encountered: