Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel head breaks RBE tests #13321

Closed
agoulti opened this issue Apr 9, 2021 · 8 comments
Closed

Bazel head breaks RBE tests #13321

agoulti opened this issue Apr 9, 2021 · 8 comments
Labels
more data needed team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Comments

@agoulti
Copy link

agoulti commented Apr 9, 2021

This is a tracking bug to ensure that all the fixes are cherrypicked into the release.

@meisterT
Copy link
Member

Can you please be more specific. What is broken, what needs to be cherry picked? Is it broken in 4.0?

@meisterT
Copy link
Member

cc @philwo

@coeuvre
Copy link
Member

coeuvre commented Apr 15, 2021

This is referring to recent changes to output paths semantics.

These changes aren't included in 4.1 release but in the future if we release 7149f57, make sure to include others 24c980b, e6f1066, 4efeac9 and #13339.

@gregestren gregestren added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Apr 15, 2021
@katre katre mentioned this issue Jul 12, 2021
9 tasks
@katre
Copy link
Member

katre commented Jul 26, 2021

@coeuvre Can you confirm that this is fine and the needed cherrypicks are present?

@coeuvre
Copy link
Member

coeuvre commented Jul 27, 2021

Yes, the needed cherrypicks are included.

@coeuvre coeuvre closed this as completed Jul 27, 2021
@sethkoehler
Copy link

Just to verify, I was clicking on the cherrypicks and the last one was a PR (#13339). Unlike the other entries (e.g., 4efeac9), I didn't see a label indicating this was included in 5.0.0-pre.20210708.4 (when I clicked on specific commits in https://github.com/bazelbuild/bazel/pull/13339/commits), I noticed there was a warning banner saying certain commits weren't included in any release (e.g., 6636dc2)? I am probably using github wrong (I don't have much experience with it), but just wanted to double check the last set of commits really is included in the release?

@katre
Copy link
Member

katre commented Jul 27, 2021

@sethkoehler Because of the degree of divergence between 4.2.0 and 5.0.0-pre, the commits require changes to merge cleanly. This changes the commit id and causes git to report that it is only on the release branch. These are still cherrypicked commits from the master branch on bazelbuild/bazel.

Some commits are also fixes for specific release blockers and may not yet be in a released version of Bazel.

@sethkoehler
Copy link

Ok, glad to hear all is well, thank you for confirming those commits are indeed in the upcoming 5.0.0 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more data needed team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

No branches or pull requests

6 participants