Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karma_web_test should resolve .umd.js.map files #764

Closed
Toxicable opened this issue May 15, 2019 · 3 comments
Closed

karma_web_test should resolve .umd.js.map files #764

Toxicable opened this issue May 15, 2019 · 3 comments
Labels
Can Close? We will close this in 30 days if there is no further activity enhancement

Comments

@Toxicable
Copy link

🚀 feature request

Relevant Rules

karma_web_test

Describe the solution you'd like

*.umd.js.map files should be automatiically resolved by karma_web_test

Describe alternatives you've considered

manually ading them

@gregmagolan
Copy link
Collaborator

gregmagolan commented May 16, 2019

The change needed is here https://github.com/bazelbuild/rules_nodejs/blob/master/internal/npm_install/generate_build_file.js#L750. Just need to add .umd.js.map to the array.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Oct 15, 2020
@github-actions
Copy link

This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? We will close this in 30 days if there is no further activity enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants