-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esbuild README could benefit from docs on required rules_nodejs version #2493
Comments
It's expected that the version of rules_nodejs in the bazel |
Might be more friendly for the tooling itself to print a warning when the versions don't match (or even error out, if that makes sense?) -- is that something that seems possible to do? I wouldn't mind contributing a PR but not exactly sure where to start |
Ah yeah, we do already have that, seems it wasn't included in the package.json postinstall for the esbuild package |
I ran into this issue when trying to use esbuild:
Guessing it's because I'm on an outdated version of
rules_nodejs
(^2.3.0
) -- but the README in@bazel/esbuild
doesn't mention which version is required -- might be useful to add docs on the required version so that other folks don't run into this issue :)The text was updated successfully, but these errors were encountered: