Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi, #2479

Closed
thakkarkrutika22 opened this issue Feb 19, 2021 · 3 comments
Closed

Hi, #2479

thakkarkrutika22 opened this issue Feb 19, 2021 · 3 comments
Labels
Can Close? We will close this in 30 days if there is no further activity

Comments

@thakkarkrutika22
Copy link

Hi,
I'm using this rule - ts_web_test_suite to run angular unit test cases with bazel.

ts_web_test_suite(
name = "unit_test",
tags = ["native", "no-bazelci"],
srcs = [
# We are manaully adding a browserify generated named UMD date-fns bundle here that
# was generated in our package.json postinstall step. This is a temporary work-around
# to get commonjs modules & npm packages working with ts_web_test_suite. A more ergonomic
# solution is planned for Angular v8. See https://github.com//issues/646.
"@npm//date-fns:date-fns.umd.js",
],
# do not sort
bootstrap = [
"@npm//:node_modules/zone.js/dist/zone-testing-bundle.js",
"@npm//:node_modules/reflect-metadata/Reflect.js",
],
browsers = [
"@io_bazel_rules_webtesting//browsers:chromium-local",
# TODO(gregmagolan): re-enable firefox testing once fixed
# See https://github.com/bazelbuild/rules_typescript/issues/296
#"@io_bazel_rules_webtesting//browsers:firefox-local",
],
runtime_deps = [
"//ui/src:initialize_testbed",
],
deps = [
":test",
"//ui/src:rxjs_umd_modules",
],
)

And I'm running this command to find the coverage report using lcov.
bazel coverage --combined_report=lcov //ui/...

But the _coverage_report.dat file generated here is empty.

Can anyone help with this?

Originally posted by @Kritz1994 in #931 (comment)

@alexeagle
Copy link
Collaborator

I bet we don't have any coverage support for karma. @Toxicable is our coverage expert - any idea whether this ought to work or how much effort?

@github-actions
Copy link

github-actions bot commented Jun 5, 2021

This issue has been automatically marked as stale because it has not had any activity for 90 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Jun 5, 2021
@github-actions
Copy link

This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? We will close this in 30 days if there is no further activity
Projects
None yet
Development

No branches or pull requests

2 participants