From ea6ee0b4f3d54c4be618d012cbe092dcbaacb8c0 Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Mon, 12 Aug 2019 13:48:20 -0700 Subject: [PATCH] fix: get rules_go dependency from build_bazel_rules_typescript we don't want to get this file through the npm package dependency --- WORKSPACE | 6 +++--- package.bzl | 9 --------- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 9bb7f96162..bbe36fb479 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -106,18 +106,18 @@ install_bazel_dependencies() # With http_archive it only sees releases/download/*.tar.gz urls git_repository( name = "build_bazel_rules_typescript", - commit = "ae6d6888ffb727f7d10918c2c2fee267de12aebb", + commit = "73ba7764363bbf760593a205329cb676095f53f9", remote = "http://github.com/bazelbuild/rules_typescript.git", ) # We have a source dependency on build_bazel_rules_typescript # so we must repeat its transitive toolchain deps -load("@npm_bazel_typescript//:package.bzl", "rules_typescript_dev_dependencies") +load("@build_bazel_rules_typescript//:package.bzl", "rules_typescript_dev_dependencies") rules_typescript_dev_dependencies() load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies") -load("@io_bazel_rules_go//go:def.bzl", "go_register_toolchains", "go_rules_dependencies") +load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") gazelle_dependencies() diff --git a/package.bzl b/package.bzl index 83d76ada67..d69254efe0 100644 --- a/package.bzl +++ b/package.bzl @@ -50,15 +50,6 @@ def rules_nodejs_dev_dependencies(): sha256 = "a3d6a8ba4c6dce86d3b3387a23b04cbdf4c435a58120bd9842588d3845fe689c", ) - # Needed by stardoc - http_archive( - name = "com_google_protobuf", - sha256 = "b404fe166de66e9a5e6dab43dc637070f950cdba2a8a4c9ed9add354ed4f6525", - strip_prefix = "protobuf-b4f193788c9f0f05d7e0879ea96cd738630e5d51", - # Commit from 2019-05-15, update to protobuf 3.8 when available. - url = "https://github.com/protocolbuffers/protobuf/archive/b4f193788c9f0f05d7e0879ea96cd738630e5d51.zip", - ) - # Needed for com_google_protobuf http_archive( name = "zlib",