From ea168a73a1c78819acd9d89d2d974013ce5db7d8 Mon Sep 17 00:00:00 2001 From: Joe Lencioni Date: Mon, 1 Feb 2021 16:48:01 -0600 Subject: [PATCH] fix(typescript): allow up to typescript 4.2, add tests for 3.7-4.1 This commit relaxes the semver range of the typescript peerDependency to allow for v4.2 and earlier. I chose this version because 4.1 has been released, and we are expecting 4.2 to be released soon. TypeScript does not follow semver, so this could probably be a bit higher, but for now this is an improvement over the current range. To support this, I added some e2e tests for some of the newer versions that are now covered in the new semver range. This should help ensure that we don't break anyone using these versions as changes are made. --- e2e/BUILD.bazel | 5 +++++ packages/typescript/package.json | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/e2e/BUILD.bazel b/e2e/BUILD.bazel index 48af4886c7..0fb5a0b531 100644 --- a/e2e/BUILD.bazel +++ b/e2e/BUILD.bazel @@ -137,4 +137,9 @@ e2e_integration_test( "3.4.x", "3.5.x", "3.6.x", + "3.7.x", + "3.8.x", + "3.9.x", + "4.0.x", + "4.1.x", ]] diff --git a/packages/typescript/package.json b/packages/typescript/package.json index a5135266a5..a415becfe0 100644 --- a/packages/typescript/package.json +++ b/packages/typescript/package.json @@ -23,7 +23,7 @@ }, "//": "note that typescript doesn't follow semver, so technically anything 3.6 or higher might break us", "peerDependencies": { - "typescript": ">=3.0.0 <4.0" + "typescript": ">=3.0.0 <4.3" }, "dependencies": { "protobufjs": "6.8.8",