Skip to content

Commit

Permalink
fix(typescript): allow up to typescript 4.2, add tests for 3.7-4.1
Browse files Browse the repository at this point in the history
This commit relaxes the semver range of the typescript peerDependency to
allow for v4.2 and earlier. I chose this version because 4.1 has been
released, and we are expecting 4.2 to be released soon. TypeScript does
not follow semver, so this could probably be a bit higher, but for now
this is an improvement over the current range.

To support this, I added some e2e tests for some of the newer versions
that are now covered in the new semver range. This should help ensure
that we don't break anyone using these versions as changes are made.
  • Loading branch information
lencioni authored and alexeagle committed Feb 2, 2021
1 parent 7ebfd1d commit ea168a7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions e2e/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,9 @@ e2e_integration_test(
"3.4.x",
"3.5.x",
"3.6.x",
"3.7.x",
"3.8.x",
"3.9.x",
"4.0.x",
"4.1.x",
]]
2 changes: 1 addition & 1 deletion packages/typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"//": "note that typescript doesn't follow semver, so technically anything 3.6 or higher might break us",
"peerDependencies": {
"typescript": ">=3.0.0 <4.0"
"typescript": ">=3.0.0 <4.3"
},
"dependencies": {
"protobufjs": "6.8.8",
Expand Down

0 comments on commit ea168a7

Please sign in to comment.