Skip to content

Commit

Permalink
fix(concatjs): devserver not passing through tags to all targets (#2646)
Browse files Browse the repository at this point in the history
If a devserver target is currently testonly and marked with the
`manual` tag (e.g. if used for e2e testing), then the `manual`
tag is not passed to all targets exposed by the ConcatJS devserver
macro. i.e. the manifest alias is exposed and results in the
manifest to be built -> which inherently means that the actual
devserver target is built even though it has the `manual` tag.
  • Loading branch information
devversion authored May 7, 2021
1 parent 7cf7d73 commit 8abc8e0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/concatjs/devserver/concatjs_devserver.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ def concatjs_devserver_macro(name, args = [], visibility = None, tags = [], test
native.alias(
name = "%s.MF" % name,
actual = "%s_launcher.MF" % name,
tags = tags,
visibility = visibility,
)

Expand Down

0 comments on commit 8abc8e0

Please sign in to comment.